From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Emmanuel Grumbach" <emmanuel.grumbach@intel.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Lukas Wunner" <lukas@wunner.de>,
"Jesse Barnes" <jbarnes@virtuousgeek.org>,
"Yinghai Lu" <yinghai@kernel.org>,
linux-kernel@vger.kernel.org,
"Dean Luick" <dean.luick@cornelisnetworks.com>,
"Jonas Dreßler" <verdre@v0yd.nl>,
stable@vger.kernel.org
Subject: Re: [PATCH v4 03/11] PCI: pciehp: Use RMW accessors for changing LNKCTL
Date: Fri, 14 Jul 2023 11:58:06 +0300 [thread overview]
Message-ID: <ZLEOHly6+Y/MBzAF@smile.fi.intel.com> (raw)
In-Reply-To: <20230713124505.94866-4-ilpo.jarvinen@linux.intel.com>
On Thu, Jul 13, 2023 at 03:44:57PM +0300, Ilpo Järvinen wrote:
> As hotplug is not the only driver touching LNKCTL, use the RMW
> capability accessor which handles concurrent changes correctly.
...
> + pcie_capability_clear_and_set_word(pdev, PCI_EXP_LNKCTL,
> + PCI_EXP_LNKCTL_LD,
> + !enable ? PCI_EXP_LNKCTL_LD : 0);
enable ? 0 : PCI_EXP_LNKCTL_LD);
easier to read and get.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-07-14 8:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 12:44 [PATCH v4 00/11] PCI: Improve PCIe Capability RMW concurrency control Ilpo Järvinen
2023-07-13 12:44 ` [PATCH v4 01/11] PCI: Add locking to RMW PCI Express Capability Register accessors Ilpo Järvinen
2023-07-13 12:44 ` [PATCH v4 02/11] PCI: Make link retraining use RMW accessors for changing LNKCTL Ilpo Järvinen
2023-07-13 12:44 ` [PATCH v4 03/11] PCI: pciehp: Use " Ilpo Järvinen
2023-07-14 8:58 ` Andy Shevchenko [this message]
2023-07-13 12:44 ` [PATCH v4 04/11] PCI/ASPM: " Ilpo Järvinen
2023-07-14 9:06 ` Andy Shevchenko
2023-07-13 12:44 ` [PATCH v4 05/11] drm/amdgpu: " Ilpo Järvinen
2023-07-13 12:45 ` [PATCH v4 06/11] drm/radeon: " Ilpo Järvinen
2023-07-13 12:45 ` [PATCH v4 07/11] net/mlx5: " Ilpo Järvinen
2023-07-13 12:45 ` [PATCH v4 08/11] wifi: ath11k: " Ilpo Järvinen
2023-07-13 12:45 ` [PATCH v4 09/11] wifi: ath12k: " Ilpo Järvinen
2023-07-13 12:45 ` [PATCH v4 10/11] wifi: ath10k: " Ilpo Järvinen
2023-07-13 12:45 ` [PATCH v4 11/11] PCI: Document the Capability accessor RMW improvements Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLEOHly6+Y/MBzAF@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=dean.luick@cornelisnetworks.com \
--cc=emmanuel.grumbach@intel.com \
--cc=hkallweit1@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=lukas@wunner.de \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
--cc=verdre@v0yd.nl \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome