From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5473EB64DC for ; Mon, 17 Jul 2023 14:18:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230093AbjGQOS2 (ORCPT ); Mon, 17 Jul 2023 10:18:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229863AbjGQOSU (ORCPT ); Mon, 17 Jul 2023 10:18:20 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8376E10DF; Mon, 17 Jul 2023 07:18:18 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="365983707" X-IronPort-AV: E=Sophos;i="6.01,211,1684825200"; d="scan'208";a="365983707" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2023 07:17:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="788667913" X-IronPort-AV: E=Sophos;i="6.01,211,1684825200"; d="scan'208";a="788667913" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 17 Jul 2023 07:17:33 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qLP2a-000J8E-12; Mon, 17 Jul 2023 17:17:32 +0300 Date: Mon, 17 Jul 2023 17:17:32 +0300 From: Andy Shevchenko To: Andrei Coardos Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, florian.fainelli@broadcom.com, linus.walleij@linaro.org, sbranden@broadcom.com, brgl@bgdev.pl, Alexandru Ardelean Subject: Re: [PATCH] gpio: bcm-kona: remove unneeded platform_set_drvdata() call Message-ID: References: <20230717125521.6369-1-aboutphysycs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230717125521.6369-1-aboutphysycs@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 17, 2023 at 03:55:21PM +0300, Andrei Coardos wrote: > The platform_set_drvdata() call was never used, ever since the driver was > originally added. > It looks like this copy+paste left-over. Possibly the author copied from a > driver that had this line, but also had a remove hook. Cool, I'll incorporate this into my series. I'll make it as v2 to avoid clashes with this one. -- With Best Regards, Andy Shevchenko