From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BFDBEB64DA for ; Tue, 18 Jul 2023 15:29:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230297AbjGRP30 (ORCPT ); Tue, 18 Jul 2023 11:29:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233637AbjGRP3Y (ORCPT ); Tue, 18 Jul 2023 11:29:24 -0400 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1046A1723 for ; Tue, 18 Jul 2023 08:29:20 -0700 (PDT) Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1qLmdW-00007C-2y; Tue, 18 Jul 2023 15:29:15 +0000 Date: Tue, 18 Jul 2023 16:29:07 +0100 From: Daniel Golle To: Srinivas Kandagatla Cc: Miquel Raynal , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] nvmem: core: clear sysfs attributes for each NVMEM device Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 18, 2023 at 03:55:56PM +0100, Srinivas Kandagatla wrote: > HI Daniel, > > On 18/07/2023 14:55, Daniel Golle wrote: > > Set nvmem_cells_group.bin_attrs to NULL in case of an NVMEM device not > > having any cells in order to make sure sysfs attributes of a previously > > registered NVMEM device are not accidentally reused for a follow-up > > device which doesn't have any cells. > > > > Fixes: 757f8b3835c9 ("nvmem: core: Expose cells through sysfs") > > These patches are dropped out of nvmem next branch as it was breaking some > existing users. Ok. I've encountered those commits in linux-next and can confirm that they were definitely also breaking things here, hence my patches at least partially fixing that. I agree that reverting them for now and reworking them seems to be the better option in this case, hence my patches won't be needed as such. > > > --srini > > Signed-off-by: Daniel Golle > > --- > > drivers/nvmem/core.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > > index 6c04a9cf6919f..70e951088826d 100644 > > --- a/drivers/nvmem/core.c > > +++ b/drivers/nvmem/core.c > > @@ -458,9 +458,10 @@ static int nvmem_populate_sysfs_cells(struct nvmem_device *nvmem) > > mutex_lock(&nvmem_mutex); > > - if (list_empty(&nvmem->cells)) > > + if (list_empty(&nvmem->cells)) { > > + nvmem_cells_group.bin_attrs = NULL; > > goto unlock_mutex; > > - > > + } > > /* Allocate an array of attributes with a sentinel */ > > ncells = list_count_nodes(&nvmem->cells); > > cells_attrs = devm_kcalloc(&nvmem->dev, ncells + 1,