From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 650B7EB64DD for ; Fri, 21 Jul 2023 10:26:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231462AbjGUK0W (ORCPT ); Fri, 21 Jul 2023 06:26:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231737AbjGUK0H (ORCPT ); Fri, 21 Jul 2023 06:26:07 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F422410FC; Fri, 21 Jul 2023 03:26:05 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10777"; a="347288336" X-IronPort-AV: E=Sophos;i="6.01,220,1684825200"; d="scan'208";a="347288336" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2023 03:26:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10777"; a="898668753" X-IronPort-AV: E=Sophos;i="6.01,220,1684825200"; d="scan'208";a="898668753" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP; 21 Jul 2023 03:26:03 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qMnKj-00HYGj-2s; Fri, 21 Jul 2023 13:26:01 +0300 Date: Fri, 21 Jul 2023 13:26:01 +0300 From: Andy Shevchenko To: Andrei Coardos Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org, Alexandru Ardelean Subject: Re: [PATCH] gpio :lp3943 :remove unneeded platform_set_drvdata() call Message-ID: References: <20230720095455.21474-1-aboutphysycs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230720095455.21474-1-aboutphysycs@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 20, 2023 at 12:54:55PM +0300, Andrei Coardos wrote: > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call, to access the private data of the driver. > Also, the private data is defined in this driver, so there is no risk of > it being accessed outside of this driver file. Is this a duplicate of previously sent the same? Please, do correct versioning of the patches and changelogs being added. -- With Best Regards, Andy Shevchenko