From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0829AC001DF for ; Fri, 21 Jul 2023 11:29:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230248AbjGUL31 (ORCPT ); Fri, 21 Jul 2023 07:29:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229681AbjGUL3Z (ORCPT ); Fri, 21 Jul 2023 07:29:25 -0400 Received: from rere.qmqm.pl (rere.qmqm.pl [91.227.64.183]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D923A2130; Fri, 21 Jul 2023 04:29:23 -0700 (PDT) Received: from remote.user (localhost [127.0.0.1]) by rere.qmqm.pl (Postfix) with ESMTPSA id 4R6nQ93Z3Bz9Y; Fri, 21 Jul 2023 13:29:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1; t=1689938962; bh=iiAFm9Sb0xeMdwNiMPT537AwN2yZokM1k5EHJ7ew/xg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CITTn8ZBorD+QLr77S4YxyuYT4mwKVe5sMOoyy/x1P46BMUtqAp/oQV/BuCfRACok 5lmz7dU2wWqyVsSlMNrzIeNvfxdzrKxcPrbkc29tYr7rqJPqDEnwIyce+pwD7VnNtW cevaMD0WFH8aKLavhw4KaSv4Wx0R3lkWDvlcp4wzrwP8jFB0UyVk4kMdBkCS7F+qXX sWI9wtP899gxOBHzjP/IkT9NosXiTsPGsWLGyIVlHgBVh2RYfhhBmNAMjuC1CDFKkL +0rrUEDVUs2la0KrXe+nXee0UrctCmDp6/g+Vk/5vrucDuYP41lQvx90NOTQ38/nkQ idOcLrPlT1agA== X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.8 at mail Date: Fri, 21 Jul 2023 13:29:20 +0200 From: =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= To: Muhammad Usama Anjum Cc: Andrei Vagin , Danylo Mocherniuk , Alex Sierra , Alexander Viro , Andrew Morton , Axel Rasmussen , Christian Brauner , Cyrill Gorcunov , Dan Williams , David Hildenbrand , Greg KH , "Gustavo A . R . Silva" , "Liam R . Howlett" , Matthew Wilcox , =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= , Mike Rapoport , Nadav Amit , Pasha Tatashin , Paul Gofman , Peter Xu , Shuah Khan , Suren Baghdasaryan , Vlastimil Babka , Yang Shi , Yun Zhou , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, kernel@collabora.com Subject: Re: fs/proc/task_mmu: Implement IOCTL for efficient page table scanning Message-ID: References: <20230713101415.108875-6-usama.anjum@collabora.com> <7eedf953-7cf6-c342-8fa8-b7626d69ab63@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7eedf953-7cf6-c342-8fa8-b7626d69ab63@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 21, 2023 at 03:48:22PM +0500, Muhammad Usama Anjum wrote: > On 7/21/23 12:28 AM, Michał Mirosław wrote: > > This is a massaged version of patch by Muhammad Usama Anjum [1] > > to illustrate my review comments and hopefully push the implementation > > efforts closer to conclusion. The changes are: > Thank you so much for this effort. I also want to reach conclusion. I'll > agree with all the changes which don't affect me. But some requirements > aren't being fulfilled with this current design. [...] > #define PAGE_IS_WPASYNC (1 << 0) > #define PAGE_IS_WRITTEN (1 << 1) > You have another new flag PAGE_IS_WPASYNC. But there is no application of > PAGE_IS_WPASYNC. We must not add a flag which don't have any user. BTW, I'm not sure I got the PAGE_IS_WPASYNC naming right - this is to designate pages that can be write-protected (are UFFD-registered I believe). Best Regards Michał Mirosław