From: Herbert Xu <herbert@gondor.apana.org.au>
To: Martin Kaiser <martin@kaiser.cx>
Cc: aric.pzqi@ingenic.com, linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: hwrng: ingenic: simplify the code
Date: Sat, 22 Jul 2023 14:13:24 +1200 [thread overview]
Message-ID: <ZLs7RGhlbdhbOUK7@gondor.apana.org.au> (raw)
In-Reply-To: <20230710202733.116133-1-martin@kaiser.cx>
On Mon, Jul 10, 2023 at 10:27:26PM +0200, Martin Kaiser wrote:
> Simplify the ingenic-trng driver a bit. Switch to devm_clk_get_enabled and
> devm_hwrng_register. Remove some unused code.
>
> The changes were compile-tested only (I don't have this hardware).
>
> Martin Kaiser (7):
> hwrng: ingenic - enable compile testing
> hwrng: ingenic - remove two unused defines
> hwrng: ingenic - remove dead assignments
> hwrng: ingenic - use devm_clk_get_enabled
> hwrng: ingenic - use dev_err_probe in error paths
> hwrng: ingenic - don't disable the rng in ingenic_trng_remove
> hwrng: ingenic - switch to device managed registration
>
> drivers/char/hw_random/Kconfig | 3 +-
> drivers/char/hw_random/ingenic-trng.c | 57 ++++++---------------------
> 2 files changed, 12 insertions(+), 48 deletions(-)
>
> --
> 2.30.2
All applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2023-07-22 2:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 20:27 Martin Kaiser
2023-07-10 20:27 ` [PATCH 1/7] hwrng: ingenic - enable compile testing Martin Kaiser
2023-07-10 20:27 ` [PATCH 2/7] hwrng: ingenic - remove two unused defines Martin Kaiser
2023-07-10 20:27 ` [PATCH 3/7] hwrng: ingenic - remove dead assignments Martin Kaiser
2023-07-10 20:27 ` [PATCH 4/7] hwrng: ingenic - use devm_clk_get_enabled Martin Kaiser
2023-07-10 20:27 ` [PATCH 5/7] hwrng: ingenic - use dev_err_probe in error paths Martin Kaiser
2023-07-10 20:27 ` [PATCH 6/7] hwrng: ingenic - don't disable the rng in ingenic_trng_remove Martin Kaiser
2023-07-10 20:27 ` [PATCH 7/7] hwrng: ingenic - switch to device managed registration Martin Kaiser
2023-07-22 2:13 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLs7RGhlbdhbOUK7@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=aric.pzqi@ingenic.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@kaiser.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®