From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62D9FC04A6A for ; Fri, 4 Aug 2023 16:57:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231403AbjHDQ5f (ORCPT ); Fri, 4 Aug 2023 12:57:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231383AbjHDQ5b (ORCPT ); Fri, 4 Aug 2023 12:57:31 -0400 Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C1E3469C for ; Fri, 4 Aug 2023 09:57:25 -0700 (PDT) Received: by mail-io1-xd34.google.com with SMTP id ca18e2360f4ac-79095499a17so85069839f.3 for ; Fri, 04 Aug 2023 09:57:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; t=1691168245; x=1691773045; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=fLs6vLbC3bot13xgwrJ/fB2v8UZa1GQgyp/C81/2sXw=; b=BQY5zzs/9I6VY6xyhPL8yq1cl+TLPbV3XxYmr4qSB+Za88/G2jhf/8k76NYDcE7Oi3 rU3ucAGOJA9FCr8AjxaFYYi4vg2b4GCVddq4kI81RtSDaH2vcAdEMTpQ45zqBLi1eaxf mHUOR2hY26v/em/o5OD44PUMC10nDsd9mzQY8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691168245; x=1691773045; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fLs6vLbC3bot13xgwrJ/fB2v8UZa1GQgyp/C81/2sXw=; b=K0D90bwjPJUc7ByaR8lpRwHLHWqWib+4jNrtqmF6LDuimYjJmmkwCGNAfHk2IQ5qzh Rc32TKjU0lbYPAtF00d4sjdjJ011UCdzcG7zXGtWTdHTiREPEQ65WvYvmWpTXFoP3LLh dwQrFaUbZILcgfJdYMxSftY63bhgMaNAojM3Xr4vIr2GvRueda9PBqcC0FT+4EUkQm/b HXHqQwwfbt2BX/O0ct4p5vn2mMG5iFtYEoHAX0Qsllp9YxWJTcFg43nU05kLiTOU530o SL9MoQ0p9MDowf0XPgA+87NM+Gt2kc/E3HvA2IMp67MPSwQNlpHTLVSu+uUd1omBl267 g6gg== X-Gm-Message-State: AOJu0YwmI8+IrklaCwSpU+qCpz6Q8M6cN1N8VRsnO5bSqDzh3mub4tC/ 9sRLsm/IJaQOQD8ptmg9hQwPBg== X-Google-Smtp-Source: AGHT+IHU3+wLh7lUmQRFHahUjU0LpvS8KkYhfTtHOyxinRVgWiVu/pjJ9WcEu15SHijdHdKkUr0kEw== X-Received: by 2002:a5d:8d95:0:b0:790:f866:d716 with SMTP id b21-20020a5d8d95000000b00790f866d716mr1101255ioj.15.1691168244913; Fri, 04 Aug 2023 09:57:24 -0700 (PDT) Received: from CMGLRV3 ([2a09:bac5:9478:4be::79:1a]) by smtp.gmail.com with ESMTPSA id z11-20020a6b0a0b000000b007791e286fdbsm753260ioi.21.2023.08.04.09.57.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Aug 2023 09:57:24 -0700 (PDT) Date: Fri, 4 Aug 2023 11:57:22 -0500 From: Frederick Lawler To: Matthew Wilcox Cc: Daniel Dao , linux-fsdevel@vger.kernel.org, Dave Chinner , kernel-team , linux-kernel , djwong@kernel.org Subject: Re: Kernel NULL pointer deref and data corruptions with xfs on 6.1 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matthew, On Thu, Jul 27, 2023 at 01:27:56PM +0100, Matthew Wilcox wrote: > On Thu, Jul 27, 2023 at 11:25:33AM +0100, Daniel Dao wrote: > > On Thu, Jul 27, 2023 at 4:27 AM Matthew Wilcox wrote: > > > > > > On Fri, Jul 21, 2023 at 11:49:04AM +0100, Daniel Dao wrote: > > > > We do not have a reproducer yet, but we now have more debugging data > > > > which hopefully > > > > should help narrow this down. Details as followed: > > > > > > > > 1. Kernel NULL pointer deferencences in __filemap_get_folio > > > > > > > > This happened on a few different hosts, with a few different repeated addresses. > > > > The addresses are 0000000000000036, 0000000000000076, > > > > 00000000000000f6. This looks > > > > like the xarray is corrupted and we were trying to do some work on a > > > > sibling entry. > > > > > > I think I have a fix for this one. Please try the attached. > > > > For some reason I do not see the attached patch. Can you resend it, or > > is it the same > > one as in https://bugzilla.kernel.org/show_bug.cgi?id=216646#c31 ? > > Yes, that's the one, sorry. I setup a kernel with this patch to deploy out. It'll take some time to see any results from that. I did run your multiorder.c changes with/without the change to lib/xarray.c and that seemed to work as intended. I didn't see any regressions across multiple seeds with our kernel config. Fred