mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: Johannes Zink <j.zink@pengutronix.de>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	patchwork-jzi@pengutronix.de, netdev@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] net: stmmac: correct MAC propagation delay
Date: Thu, 27 Jul 2023 06:36:43 -0700	[thread overview]
Message-ID: <ZMJy6yt4CL250x6Q@hoboy.vegasvil.org> (raw)
In-Reply-To: <729dd79e-83aa-0237-1edd-1662a6ae28cd@pengutronix.de>

On Thu, Jul 27, 2023 at 09:20:10AM +0200, Johannes Zink wrote:
> Hi Richard,
> 
> On 7/26/23 22:57, Richard Cochran wrote:
> > On Mon, Jul 24, 2023 at 12:01:31PM +0200, Johannes Zink wrote:
> > 
> > Earlier versions of the IP core return zero from these...
> > 
> > > +#define	PTP_TS_INGR_LAT	0x68	/* MAC internal Ingress Latency */
> > > +#define	PTP_TS_EGR_LAT	0x6c	/* MAC internal Egress Latency */
> > 
> 
> good catch. Gonna send a v3 with a check to and set the values for dwmac v5 only.

AFAICT there is no feature bit that indicates the presence or absence
of these two registers.

Are you sure that *all* v5 IP cores have these?

I am not sure.

Thanks,
Richard

  reply	other threads:[~2023-07-27 13:36 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-24 10:01 Johannes Zink
2023-07-26  3:06 ` Jakub Kicinski
2023-07-26  3:22   ` Richard Cochran
2023-07-26  3:39     ` Jakub Kicinski
2023-07-26  6:04     ` Marc Kleine-Budde
2023-07-26 15:34       ` Richard Cochran
2023-07-27  6:40         ` Johannes Zink
2023-07-27 13:30           ` Richard Cochran
2023-07-26  6:10     ` Johannes Zink
2023-07-26 15:43       ` Richard Cochran
2023-07-27  6:39         ` Johannes Zink
2023-07-27  6:55           ` Johannes Zink
2023-07-27  7:41             ` Johannes Zink
2023-07-27  7:15           ` Kurt Kanzenbach
2023-07-27  7:18             ` Johannes Zink
2023-07-26  5:50   ` Marc Kleine-Budde
2023-07-26  3:50 ` patchwork-bot+netdevbpf
2023-07-26 18:00 ` Richard Cochran
2023-07-27  6:42   ` Johannes Zink
2023-07-27 13:34     ` Richard Cochran
2023-07-26 20:57 ` Richard Cochran
2023-07-27  7:20   ` Johannes Zink
2023-07-27 13:36     ` Richard Cochran [this message]
2023-07-31  7:00       ` Johannes Zink
2023-07-31 13:44         ` Richard Cochran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZMJy6yt4CL250x6Q@hoboy.vegasvil.org \
    --to=richardcochran@gmail.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=j.zink@pengutronix.de \
    --cc=joabreu@synopsys.com \
    --cc=kernel@pengutronix.de \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux@armlinux.org.uk \
    --cc=lkp@intel.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=patchwork-jzi@pengutronix.de \
    --cc=peppe.cavallaro@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®