From: Christoph Hellwig <hch@infradead.org>
To: Jinyoung Choi <j-young.choi@samsung.com>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"chaitanya.kulkarni@wdc.com" <chaitanya.kulkarni@wdc.com>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Subject: Re: [PATCH v2 3/4] bio-integrity: cleanup adding integrity pages to bip's bvec
Date: Tue, 1 Aug 2023 03:03:14 -0700 [thread overview]
Message-ID: <ZMjYYtXgzn86UIF8@infradead.org> (raw)
In-Reply-To: <20230731125459epcms2p177a5cc5caa7ef0a9de35689e96558f43@epcms2p1>
On Mon, Jul 31, 2023 at 09:54:59PM +0900, Jinyoung Choi wrote:
> The bio_integrity_add_page() returns the set length if the execution
> result is successful. Otherwise, return 0.
>
> Unnecessary if statement was removed. And when the result value was less
> than the set value, it was changed to failed.
Maybe word this as
bio_integrity_add_page() returns the add length if successful, else 0,
just as bio_add_page. Simply check return value checking in
bio_integrity_prep to not deal with a > 0 but < len case that can't
happen.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-08-01 10:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230731124710epcms2p55b4d1a163b5ee6f15d96bf07817e12a5@epcms2p5>
2023-07-31 12:47 ` [PATCH v2 0/4] multi-page bvec configuration for integrity payload Jinyoung Choi
[not found] ` <CGME20230731124710epcms2p55b4d1a163b5ee6f15d96bf07817e12a5@epcms2p7>
2023-07-31 12:52 ` [PATCH v2 2/4] bio-integrity: Sets the payload size in bio_integrity_add_page() Jinyoung Choi
2023-08-01 9:59 ` Christoph Hellwig
[not found] ` <CGME20230731124710epcms2p55b4d1a163b5ee6f15d96bf07817e12a5@epcms2p1>
2023-07-31 12:50 ` [PATCH v2 1/4] block: make bvec_try_merge_hw_page() non-static Jinyoung Choi
2023-07-31 12:54 ` [PATCH v2 3/4] bio-integrity: cleanup adding integrity pages to bip's bvec Jinyoung Choi
2023-08-01 10:03 ` Christoph Hellwig [this message]
[not found] ` <CGME20230731124710epcms2p55b4d1a163b5ee6f15d96bf07817e12a5@epcms2p3>
2023-08-03 1:48 ` Jinyoung Choi
2023-07-31 12:56 ` [PATCH v2 4/4] bio-integrity: create multi-page bvecs in bio_integrity_add_page() Jinyoung Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMjYYtXgzn86UIF8@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=chaitanya.kulkarni@wdc.com \
--cc=j-young.choi@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®