From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Christoph Hellwig <hch@lst.de>,
syzbot <syzbot+ae97a827ae1c3336bbb4@syzkaller.appspotmail.com>,
clm@fb.com, dsterba@suse.com, johannes.thumshirn@wdc.com,
josef@toxicpanda.com, linux-btrfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [btrfs?] kernel BUG in prepare_to_merge
Date: Tue, 1 Aug 2023 08:26:08 -0700 [thread overview]
Message-ID: <ZMkkEEQVr1T/p/vJ@infradead.org> (raw)
In-Reply-To: <ZMju6PMnJ6tnMgfy@infradead.org>
In the meantime I've also reproduced it with just
"btrfs: fix the btrfs_get_global_root return value", but it took
a rather long time.
After wading through the code my suspicion is that before this fix
the ERR_PTR return made that for those cases btrfs_get_root_ref and
btrfs_get_fs_root_commit_root don't actually do the
btrfs_lookup_fs_root. Although that seemed unintentional as far
as I can tell it might have prevented some additional problems
with whatever syzcaller is fuzzing here. Not sure if anyone who
knows this code has any good idea where to start looking?
next prev parent reply other threads:[~2023-08-01 15:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-01 20:46 syzbot
2023-07-03 5:10 ` syzbot
2023-07-30 17:07 ` syzbot
2023-07-31 5:11 ` Qu Wenruo
2023-07-31 5:26 ` Qu Wenruo
2023-08-01 14:37 ` Aleksandr Nogikh
2023-08-01 14:58 ` syzbot
2023-08-02 5:19 ` Qu Wenruo
2023-08-02 5:35 ` syzbot
2023-07-31 2:13 ` syzbot
2023-07-31 7:37 ` Christoph Hellwig
2023-07-31 8:12 ` Qu Wenruo
2023-07-31 9:46 ` Christoph Hellwig
2023-07-31 10:01 ` Qu Wenruo
2023-08-01 11:39 ` Christoph Hellwig
2023-08-01 15:26 ` Christoph Hellwig [this message]
2023-08-02 6:53 ` Qu Wenruo
2023-08-01 22:19 ` Qu Wenruo
2023-08-02 9:12 ` Qu Wenruo
2023-08-02 9:32 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMkkEEQVr1T/p/vJ@infradead.org \
--to=hch@infradead.org \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=hch@lst.de \
--cc=johannes.thumshirn@wdc.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=syzbot+ae97a827ae1c3336bbb4@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®