From: Nicolas Schier <nicolas@fjasle.eu>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Ben Hutchings <ben@decadent.org.uk>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH v2 2/2] kbuild: deb-pkg: split debian/rules
Date: Tue, 1 Aug 2023 21:56:57 +0200 [thread overview]
Message-ID: <ZMljieecB8nlQcMR@fjasle.eu> (raw)
In-Reply-To: <20230801121926.1677205-2-masahiroy@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 566 bytes --]
On Tue, Aug 01, 2023 at 09:19:26PM +0900 Masahiro Yamada wrote:
> debian/rules is generated by shell, but the escape sequence (\$) is
> unreadable.
>
> debian/rules embeds only two variables (ARCH and KERNELRELEASE).
>
> Split them out to debian/rules.vars, and check-in the rest of Makefile
> code to scripts/package/debian/rules.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> Changes in v2:
> - Change ${MAKE} to $(MAKE) for consistency
> - Fix shellcheck warning
>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-08-01 19:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 12:19 [PATCH v2 1/2] kbuild: deb-pkg: use Debian compliant shebang for debian/rules Masahiro Yamada
2023-08-01 12:19 ` [PATCH v2 2/2] kbuild: deb-pkg: split debian/rules Masahiro Yamada
2023-08-01 16:52 ` Nathan Chancellor
2023-08-01 19:56 ` Nicolas Schier [this message]
2023-08-01 16:52 ` [PATCH v2 1/2] kbuild: deb-pkg: use Debian compliant shebang for debian/rules Nathan Chancellor
2023-08-01 19:55 ` Nicolas Schier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMljieecB8nlQcMR@fjasle.eu \
--to=nicolas@fjasle.eu \
--cc=ben@decadent.org.uk \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®