From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68A07C04E69 for ; Wed, 2 Aug 2023 16:31:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231911AbjHBQbA (ORCPT ); Wed, 2 Aug 2023 12:31:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230352AbjHBQa6 (ORCPT ); Wed, 2 Aug 2023 12:30:58 -0400 Received: from mgamail.intel.com (unknown [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A2992103; Wed, 2 Aug 2023 09:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690993857; x=1722529857; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=SlGswAwlAjq4WiwF81fXJRiJ5jzv9+AjmUr0rgLvFgg=; b=fKMzSa3Y/larMNMdGejhpyImLcdNBZ6hNHPLbBxxLi74RuJDkm9HPb/r bRfEcO2KxXE2l1qlsfaWlVte92Xcer05PDQ98n4FVFqoemqy+JNeYLEaI rXUdUWUYje2rxCjjk5IAM6eKYOgF8Jf4LtaFTA+L9SyTKLBEVieq4NEuJ 9B+igiXDppnPUU2zYE537S8VnO+s35jKS1oAzZTu0b6tU83N5tkVQUg+W Y3m+qUx9J3ZXi03vZJi/bHBc+OD+JDKy0OWrvDmAmi3OJzwqgS5/ufUWy 6vbw/RCTzI2S2IPFnNgugFL1kqjFpgAqQN+zmFT7wL4wdCMO+8xurSxrC g==; X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="435956073" X-IronPort-AV: E=Sophos;i="6.01,249,1684825200"; d="scan'208";a="435956073" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2023 09:29:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="722910510" X-IronPort-AV: E=Sophos;i="6.01,249,1684825200"; d="scan'208";a="722910510" Received: from aschofie-mobl2.amr.corp.intel.com (HELO aschofie-mobl2) ([10.212.146.50]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2023 09:29:25 -0700 Date: Wed, 2 Aug 2023 09:29:23 -0700 From: Alison Schofield To: Ira Weiny Cc: Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Vishal Verma , Dan Williams , linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] cxl/mbox: Add handle to event processing debug Message-ID: References: <20230731-cxl-fix-clear-event-debug-print-v2-0-9bdd08d386e9@intel.com> <20230731-cxl-fix-clear-event-debug-print-v2-2-9bdd08d386e9@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230731-cxl-fix-clear-event-debug-print-v2-2-9bdd08d386e9@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 01, 2023 at 01:13:29PM -0700, Ira Weiny wrote: > Knowing which handle is being processed helped in debugging new event > code. Add a dev_dbg() message with this information. > > Signed-off-by: Ira Weiny > --- > drivers/cxl/core/mbox.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > index a1c490f66bbf..f052d5f174ee 100644 > --- a/drivers/cxl/core/mbox.c > +++ b/drivers/cxl/core/mbox.c > @@ -947,9 +947,13 @@ static void cxl_mem_get_records_log(struct cxl_memdev_state *mds, > if (!nr_rec) > break; > > - for (i = 0; i < nr_rec; i++) > + for (i = 0; i < nr_rec; i++) { > + dev_dbg(dev, "Event log %d: processing handle %u\n", > + type, > + le16_to_cpu(payload->records[i].hdr.handle)); > cxl_event_trace_record(cxlmd, type, > &payload->records[i]); > + } Is dev_dbg() overkill when the info is in the trace event? > > if (payload->flags & CXL_GET_EVENT_FLAG_OVERFLOW) > trace_cxl_overflow(cxlmd, type, payload); > > -- > 2.41.0 >