From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99519C3065B for ; Thu, 17 Aug 2023 15:47:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353318AbjHQPr2 (ORCPT ); Thu, 17 Aug 2023 11:47:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234656AbjHQPrY (ORCPT ); Thu, 17 Aug 2023 11:47:24 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD24A30D1 for ; Thu, 17 Aug 2023 08:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692287243; x=1723823243; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=MCSLwMZ4WasZRVsOE5qv9ujXSf/pPYVAtXBsbhfemIQ=; b=KbMn/XGKQJuNpjbkzxdYiR5yt4QptFKQmYg0VZ4bs7ygXxzOaSOnjEBj z06FbLoa9CbREqcHY+k2KP3t8uraLtyXMOGHerHPH4ure0Oheq0YsFSIB el+xEQOvRoiG2bsUcA8DB5yCfrj7js5p164zzkr3xnrdJQWuKoK40pd6h CA5SNO0ClxnfyU2b+DsJbhZvpSjre76AJrXUN36611qBxPK8sSWzlWy+c VNRE5i2SIN8+vdYtKwtG734rq9E4iwnlGrfS+jHY0Sb1V4+AlGTmKzPFr NxnF/ywx+4CJ56FYzLhzogQXuJy/DnV4lY2x65O37b3DxtIp6r5EG8TK1 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10805"; a="353157702" X-IronPort-AV: E=Sophos;i="6.01,180,1684825200"; d="scan'208";a="353157702" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2023 08:47:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10805"; a="728180615" X-IronPort-AV: E=Sophos;i="6.01,180,1684825200"; d="scan'208";a="728180615" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 17 Aug 2023 08:47:20 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qWfDS-000YEt-30; Thu, 17 Aug 2023 18:47:18 +0300 Date: Thu, 17 Aug 2023 18:47:18 +0300 From: Andy Shevchenko To: Yury Norov Cc: linux-kernel@vger.kernel.org, Rasmus Villemoes Subject: Re: [PATCH v3 1/8] bitmap: align __reg_op() wrappers with modern coding style Message-ID: References: <20230815233628.45016-1-yury.norov@gmail.com> <20230815233628.45016-2-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 17, 2023 at 07:22:25AM -0700, Yury Norov wrote: > On Thu, Aug 17, 2023 at 12:39:49PM +0300, Andy Shevchenko wrote: > > On Tue, Aug 15, 2023 at 04:36:21PM -0700, Yury Norov wrote: > > > Fix comments so that scripts/kernel-doc doesn't warn, and fix for-loop > > > style in bitmap_find_free_region(). > > > > Suggested-by? > > Can you send a full tag? I thought it's easy to get... Nevertheless it's here. Suggested-by: Andy Shevchenko > > Reviewed-by: Andy Shevchenko Btw, there are things needs to be fixed/improved as well: 1) bitmap_pos_to_ord(): reference to @nbits instead of @bits; 2) bitmap_parse(): wrong/confusing reference to a list, while should be better example for under 32-bit input and over it with spaces and/or commas; 3) style of the descriptions of the parameters: * @param : vs. * @param: /// preferable 4) bitmap_cut(): make nbits a reference as @nbits in some cases; 5) empty line after the function summary (should be dropped), e.g. in bitmap_parse_user(); 6) true and false can be referred )in bitmap_print_to_buf(), for example) as constants %true. %false (up to you). Maybe something else... That said, the documentation should be revisited carefully. -- With Best Regards, Andy Shevchenko