From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
"open list:PIN CONTROL SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"moderated list:BROADCOM IPROC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] pinctrl: iproc-gpio: Silence probe deferral messages
Date: Tue, 8 Aug 2023 16:09:24 +0300 [thread overview]
Message-ID: <ZNI+hLy4jYgctYXX@smile.fi.intel.com> (raw)
In-Reply-To: <20230807213022.1862903-2-florian.fainelli@broadcom.com>
On Mon, Aug 07, 2023 at 02:30:21PM -0700, Florian Fainelli wrote:
> We can have gpiochip_add_data() return -EPROBE_DEFER which will make us
> produce the "unable to add GPIO chip" message which is confusing. Use
> dev_err_probe() to silence probe deferral messages.
...
> ret = gpiochip_add_data(gc, chip);
> if (ret < 0) {
> - dev_err(dev, "unable to add GPIO chip\n");
> + dev_err_probe(dev, ret, "unable to add GPIO chip\n");
> return ret;
return dev_err_probe(...);
> }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-08 18:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 21:30 [PATCH 0/2] pinctrl: bcm: Use dev_err_probe() Florian Fainelli
2023-08-07 21:30 ` [PATCH 1/2] pinctrl: iproc-gpio: Silence probe deferral messages Florian Fainelli
2023-08-08 13:09 ` Andy Shevchenko [this message]
2023-08-07 21:30 ` [PATCH 2/2] pinctrl: nsp-gpio: " Florian Fainelli
2023-08-08 13:09 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNI+hLy4jYgctYXX@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®