From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90AA0C04A6A for ; Tue, 8 Aug 2023 17:05:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233932AbjHHRF0 (ORCPT ); Tue, 8 Aug 2023 13:05:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229706AbjHHREo (ORCPT ); Tue, 8 Aug 2023 13:04:44 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB2EB19BEA; Tue, 8 Aug 2023 09:02:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691510524; x=1723046524; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=tMJrfIaDobN4ipiyrDWHuNHNte9Iz5SKbwSXc9SphBo=; b=CXa15VOHxdqZP5y1ceXt4R+I1f7QOD6G1f/xbAFLFN1c6HsYyZ4RCuoR xIwZ5/ihEPpbWhjrfqiFJLUABxTC+gZXShkuf7THec5s3Ef9R+N2QlAnY EtkEI6INjxcfTuLI8FL+zQGQ1FUr+8p5SrUsF3L4ND9jkaEeOKbFbmo6l O1Za/ELQPXoQNFfiPuRfW4FMAduzpf51jD7D+cHNdauzwhR7r18u/14gH wFO7fq5FHtCzqHLOHZWTOeVnGcAJGlopuwx/PH7+1uUk+mMrNDD5GrwqH FvQGKoF9sqXp10V9GzQN2W1gwRYCr5OomdlGk3Z/I5GU7D87utmm2OlrC Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="373575133" X-IronPort-AV: E=Sophos;i="6.01,156,1684825200"; d="scan'208";a="373575133" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2023 06:53:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="724930236" X-IronPort-AV: E=Sophos;i="6.01,156,1684825200"; d="scan'208";a="724930236" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 08 Aug 2023 06:53:53 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qTN9j-00AdSU-01; Tue, 08 Aug 2023 16:53:51 +0300 Date: Tue, 8 Aug 2023 16:53:50 +0300 From: Andy Shevchenko To: Jonathan Cameron Cc: Wenhua Lin , Dmitry Torokhov , Nuno =?iso-8859-1?Q?S=E1?= , Arnd Bergmann , Samuel Holland , Robert Jarzmik , Mattijs Korpershoek , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, wenhua lin , Xiongpeng Wu Subject: Re: [PATCH] input: keyboard: Add sprd-keypad driver Message-ID: References: <20230808072501.3393-1-Wenhua.Lin@unisoc.com> <20230808100721.00006775@Huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230808100721.00006775@Huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 08, 2023 at 10:07:21AM +0100, Jonathan Cameron wrote: > On Tue, 8 Aug 2023 15:25:01 +0800 > Wenhua Lin wrote: ... > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + data->base = devm_ioremap_resource(&pdev->dev, res); > > devm_platform_get_and_ioremap_resource) Is res used anywhere else? > > + if (IS_ERR(data->base)) { > > + dev_err(&pdev->dev, "ioremap resource failed.\n"); > > + ret = PTR_ERR(data->base); > > + goto err_free; > > Read up on what devm calls do - there is no need to manually free > things that were allocated with them in the error paths or remove. > So this should be a direct return. Also use > return dev_err_probe(&pdev->dev, PTR_ERR(data->base), > "....") Btw, with struct device *dev = &pdev->dev; all these become neater. > It both creates neater code and for cases where deferred probing > is possible you will get a nice message on 'why' registered for > debug purposes. > > > + } -- With Best Regards, Andy Shevchenko