From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11578C04A6A for ; Thu, 10 Aug 2023 16:47:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234573AbjHJQrO (ORCPT ); Thu, 10 Aug 2023 12:47:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234337AbjHJQrL (ORCPT ); Thu, 10 Aug 2023 12:47:11 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACE9C90 for ; Thu, 10 Aug 2023 09:47:11 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-26813cd7a8aso757269a91.2 for ; Thu, 10 Aug 2023 09:47:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1691686031; x=1692290831; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Z1YxxQSx9jryP/gaiSlpxrcgwKgQeQJEh/0X+pazM0o=; b=ce/9DcrCCwo6KPfVtyNMNZolyHGIshD4DR/Wwxcjvjqlu2XZC2ifdrhTlTMfIbIpeQ 9b90fyURIEL5MZ9OfK9porDeciE520+G8QtnkKssJ+XxcxmmKkEaLPYgHq4/SWdDOjy8 LlUjLXgVmYkOjGqOVyfTuMXSsLpV2rW7vChHQJrQWZmlTTBgJZJmxuZGZCMimvei99rP ghT4UMiwO3FVTv8qcE912BIbrT9fazw4xMd4nFj5YEFvMO+dnOCEyHVFG65Bia2hYzwq FxjZlGsyOIbe7GeyLd73rYRo4u1SYKYuPYchLPh0qDZ11YpBFSFTWWKehNUhm+P8FcbT uitw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691686031; x=1692290831; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z1YxxQSx9jryP/gaiSlpxrcgwKgQeQJEh/0X+pazM0o=; b=ZdkmnACwpcNNT2IcI3Oqxo6m+1gYXMH64rEAoGOQJcjzzaSpEVl3hcnLQDgcuDEPNB xijVd6pKjpVYfKUChGsTCAa3kOgLfvGkXxK3EOcMmqusQ0v728KjkyZT43Yhb4DFroZL 6uPujvkpiy8EL3mlziXVXku8s3BqlsIrYldhPHCuEtiVeTQ+fdzhBewmygCJIlTkOwoh lhm661SVqqDa9jGs0IWj0cAIQXuQFl/pJ8X3GcZLKkDaJOStiQy/9+TZ/GSLhfXTXpvF 7FnNIkVaBmB8vraU9loTo6ugZ2gnEnvr1sTNe4rbKQr3KWv5rTD/isOkJ+ZoGue0lgPq vOuQ== X-Gm-Message-State: AOJu0YzFvijK6prqiPgVC9yFfeLJce616X6RkaQ8LgupYnffUCH7hhKC OEzNcbmAn1zQ0initYuEUVjJ0w== X-Google-Smtp-Source: AGHT+IEW7khYL0o4UiJXTotcmkvmJTY67L4z884ZB/Rx1B6m1oAZwsmTvmxd1WH9hKUE9QQ1nrFRXQ== X-Received: by 2002:a17:90a:ba92:b0:268:300b:ee82 with SMTP id t18-20020a17090aba9200b00268300bee82mr2781613pjr.19.1691686031121; Thu, 10 Aug 2023 09:47:11 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id 19-20020a17090a1a5300b0026851759e9csm1842689pjl.29.2023.08.10.09.47.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 09:47:10 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1qU8oX-005H7B-4H; Thu, 10 Aug 2023 13:47:09 -0300 Date: Thu, 10 Aug 2023 13:47:09 -0300 From: Jason Gunthorpe To: "Tian, Kevin" Cc: Baolu Lu , Joerg Roedel , Will Deacon , Robin Murphy , Jean-Philippe Brucker , Nicolin Chen , "Liu, Yi L" , Jacob Pan , "iommu@lists.linux.dev" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 08/12] iommu: Prepare for separating SVA and IOPF Message-ID: References: <20230727054837.147050-1-baolu.lu@linux.intel.com> <20230727054837.147050-9-baolu.lu@linux.intel.com> <0771c28d-1b31-003e-7659-4f3f3cbf5546@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 10, 2023 at 02:35:40AM +0000, Tian, Kevin wrote: > > From: Baolu Lu > > Sent: Wednesday, August 9, 2023 6:41 PM > > > > On 2023/8/9 8:02, Tian, Kevin wrote: > > >> From: Jason Gunthorpe > > >> Sent: Wednesday, August 9, 2023 2:43 AM > > >> > > >> On Thu, Aug 03, 2023 at 08:16:47AM +0000, Tian, Kevin wrote: > > >> > > >>> Is there plan to introduce further error in the future? otherwise this > > should > > >>> be void. > > >>> > > >>> btw the work queue is only for sva. If there is no other caller this can be > > >>> just kept in iommu-sva.c. No need to create a helper. > > >> > > >> I think more than just SVA will need a work queue context to process > > >> their faults. > > >> > > > > > > then this series needs more work. Currently the abstraction doesn't > > > include workqueue in the common fault reporting layer. > > > > Do you mind elaborate a bit here? workqueue is a basic infrastructure in > > the fault handling framework, but it lets the consumers choose to use > > it, or not to. > > > > My understanding of Jason's comment was to make the workqueue the > default path instead of being opted by the consumer.. that is my 1st > impression but might be wrong... Yeah, that is one path. Do we have anyone that uses this that doesn't want the WQ? (actually who even uses this besides SVA?) Jason