From: Alexon Oliveira <alexondunkan@gmail.com>
To: gregkh@linuxfoundation.org
Cc: martyn@welchs.me.uk, manohar.vanga@gmail.com,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: [PATCH] staging: vme_user: fix check unnecessary parentheses
Date: Mon, 14 Aug 2023 17:08:19 -0300 [thread overview]
Message-ID: <ZNqJs126kA+KvSTC@alolivei-thinkpadt480s.gru.csb> (raw)
Fixed all CHECK: Unnecessary parentheses around
as reported by checkpatch to adhere to the Linux kernel
coding-style guidelines.
Signed-off-by: Alexon Oliveira <alexondunkan@gmail.com>
---
drivers/staging/vme_user/vme.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c
index c7c50406c199..6f08bb21369d 100644
--- a/drivers/staging/vme_user/vme.c
+++ b/drivers/staging/vme_user/vme.c
@@ -307,7 +307,7 @@ struct vme_resource *vme_slave_request(struct vme_dev *vdev, u32 address,
mutex_lock(&slave_image->mtx);
if (((slave_image->address_attr & address) == address) &&
((slave_image->cycle_attr & cycle) == cycle) &&
- (slave_image->locked == 0)) {
+ slave_image->locked == 0) {
slave_image->locked = 1;
mutex_unlock(&slave_image->mtx);
allocated_image = slave_image;
@@ -508,7 +508,7 @@ struct vme_resource *vme_master_request(struct vme_dev *vdev, u32 address,
if (((master_image->address_attr & address) == address) &&
((master_image->cycle_attr & cycle) == cycle) &&
((master_image->width_attr & dwidth) == dwidth) &&
- (master_image->locked == 0)) {
+ master_image->locked == 0) {
master_image->locked = 1;
spin_unlock(&master_image->lock);
allocated_image = master_image;
@@ -882,7 +882,7 @@ struct vme_resource *vme_dma_request(struct vme_dev *vdev, u32 route)
/* Find an unlocked and compatible controller */
mutex_lock(&dma_ctrlr->mtx);
if (((dma_ctrlr->route_attr & route) == route) &&
- (dma_ctrlr->locked == 0)) {
+ dma_ctrlr->locked == 0) {
dma_ctrlr->locked = 1;
mutex_unlock(&dma_ctrlr->mtx);
allocated_ctrlr = dma_ctrlr;
@@ -1248,9 +1248,9 @@ void vme_bus_error_handler(struct vme_bridge *bridge,
list_for_each(handler_pos, &bridge->vme_error_handlers) {
handler = list_entry(handler_pos, struct vme_error_handler,
list);
- if ((aspace == handler->aspace) &&
- (address >= handler->start) &&
- (address < handler->end)) {
+ if (aspace == handler->aspace &&
+ address >= handler->start &&
+ address < handler->end) {
if (!handler->num_errors)
handler->first_error = address;
if (handler->num_errors != UINT_MAX)
@@ -1337,7 +1337,7 @@ int vme_irq_request(struct vme_dev *vdev, int level, int statid,
return -EINVAL;
}
- if ((level < 1) || (level > 7)) {
+ if (level < 1 || level > 7) {
printk(KERN_ERR "Invalid interrupt level\n");
return -EINVAL;
}
@@ -1386,7 +1386,7 @@ void vme_irq_free(struct vme_dev *vdev, int level, int statid)
return;
}
- if ((level < 1) || (level > 7)) {
+ if (level < 1 || level > 7) {
printk(KERN_ERR "Invalid interrupt level\n");
return;
}
@@ -1433,7 +1433,7 @@ int vme_irq_generate(struct vme_dev *vdev, int level, int statid)
return -EINVAL;
}
- if ((level < 1) || (level > 7)) {
+ if (level < 1 || level > 7) {
printk(KERN_WARNING "Invalid interrupt level\n");
return -EINVAL;
}
--
2.41.0
next reply other threads:[~2023-08-14 20:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 20:08 Alexon Oliveira [this message]
2023-08-14 20:16 ` Greg KH
2023-08-14 20:45 ` Alexon Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNqJs126kA+KvSTC@alolivei-thinkpadt480s.gru.csb \
--to=alexondunkan@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manohar.vanga@gmail.com \
--cc=martyn@welchs.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®