From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97662C001E0 for ; Tue, 15 Aug 2023 10:59:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236581AbjHOK7I (ORCPT ); Tue, 15 Aug 2023 06:59:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236560AbjHOK6k (ORCPT ); Tue, 15 Aug 2023 06:58:40 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE48BB3 for ; Tue, 15 Aug 2023 03:58:38 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 9D2F221986; Tue, 15 Aug 2023 10:58:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1692097117; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TjwLfv27498tFzVSmNurY4B5Fz6kQ6juEBRem4lqZwI=; b=nCzEACRxHN9GdHj0/9XXEm1Jul4w1kPJ5CA4Knrn3M3HGPhABhXiWAu24izy8W43tZihlz yWSfPMob/aKWs+bhK6g2zHAvvLfk0GkNN1N7Hw+kbXCgT/YUrUHzetuFsr5GTeXaVcFN9s nssEb7ePbNgNzINEC4A1hXR31pTwtvM= Received: from suse.cz (pmladek.udp.ovpn2.prg.suse.de [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 582962C143; Tue, 15 Aug 2023 10:58:37 +0000 (UTC) Date: Tue, 15 Aug 2023 12:58:36 +0200 From: Petr Mladek To: Andy Shevchenko Cc: Marco Elver , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Alexander Potapenko , Dmitry Vyukov , Andrew Morton Subject: Re: [PATCH v3 2/2] lib/vsprintf: Declare no_hash_pointers in sprintf.h Message-ID: References: <20230814163344.17429-1-andriy.shevchenko@linux.intel.com> <20230814163344.17429-3-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230814163344.17429-3-andriy.shevchenko@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2023-08-14 19:33:44, Andy Shevchenko wrote: > Sparse is not happy to see non-static variable without declaration: > lib/vsprintf.c:61:6: warning: symbol 'no_hash_pointers' was not declared. Should it be static? > > Declare respective variable in the sprintf.h. With this, add a comment > to discourage its use if no real need. > > Signed-off-by: Andy Shevchenko > Acked-by: Marco Elver Reviewed-by: Petr Mladek Best Regards, Petr