From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Lee Jones <lee@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mfd: max77541: Simplify probe()
Date: Tue, 29 Aug 2023 17:53:10 +0300 [thread overview]
Message-ID: <ZO4GViBrAvAG5EPT@smile.fi.intel.com> (raw)
In-Reply-To: <20230828153805.78421-1-biju.das.jz@bp.renesas.com>
On Mon, Aug 28, 2023 at 04:38:05PM +0100, Biju Das wrote:
> Simplify probe() by replacing device_get_match_data() and ID lookup for
> retrieving match data by i2c_get_match_data().
...
> While at it, drop leading commas from OF table.
Sure?
...
> static const struct of_device_id max77541_of_id[] = {
> - {
> - .compatible = "adi,max77540",
> - .data = (void *)MAX77540,
> - },
> - {
> - .compatible = "adi,max77541",
> - .data = (void *)MAX77541,
> - },
> + { .compatible = "adi,max77540", .data = (void *)MAX77540 },
> + { .compatible = "adi,max77541", .data = (void *)MAX77541 },
> { }
> };
Seems to me an unneeded churn as nothing has been changed here
(except commas and indentation). If any, it should be a separate
change.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-29 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 15:38 Biju Das
2023-08-29 14:53 ` Andy Shevchenko [this message]
2023-08-29 14:58 ` Biju Das
2023-08-29 15:09 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO4GViBrAvAG5EPT@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®