From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] regulator: pv880x0: Simplify probe()
Date: Tue, 29 Aug 2023 18:11:36 +0300 [thread overview]
Message-ID: <ZO4KqF+gnJDlWvRB@smile.fi.intel.com> (raw)
In-Reply-To: <20230828172417.113631-2-biju.das.jz@bp.renesas.com>
On Mon, Aug 28, 2023 at 06:24:16PM +0100, Biju Das wrote:
> Replace pv88080_types->pv88080_compatible_regmap in OF/ID tables and
> simplify the probe() by replacing of_match_node() and ID lookup for
> retrieving match data by i2c_get_match_data(). After this there is
> no user of enum pv88080_types. So drop it.
>
> While at it, remove trailing comma in the terminator entry for OF/ID
> tables.
...
> +#ifdef CONFIG_OF
Do you still need this? (Perhaps in a separate patch to remove?)
...
> +static const struct of_device_id pv88080_dt_ids[] = {
> + { .compatible = "pvs,pv88080", .data = &pv88080_aa_regs },
> + { .compatible = "pvs,pv88080-aa", .data = &pv88080_aa_regs },
One space too many.
> + { .compatible = "pvs,pv88080-ba", .data = &pv88080_ba_regs },
> + {}
> +};
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-29 15:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 17:24 [PATCH v2 0/2] Match dtat improvements for pv880x0 regulator driver Biju Das
2023-08-28 17:24 ` [PATCH v2 1/2] regulator: pv880x0: Simplify probe() Biju Das
2023-08-29 15:11 ` Andy Shevchenko [this message]
2023-08-29 15:12 ` Andy Shevchenko
2023-08-28 17:24 ` [PATCH v2 2/2] regulator: pv880x0: Drop CONFIG_OF ifdeffery Biju Das
2023-08-29 15:15 ` Andy Shevchenko
2023-09-12 13:29 ` [PATCH v2 0/2] Match dtat improvements for pv880x0 regulator driver Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO4KqF+gnJDlWvRB@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®