From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 412F2C71153 for ; Tue, 29 Aug 2023 15:18:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237057AbjH2PSS (ORCPT ); Tue, 29 Aug 2023 11:18:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237153AbjH2PRt (ORCPT ); Tue, 29 Aug 2023 11:17:49 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D953194 for ; Tue, 29 Aug 2023 08:17:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693322266; x=1724858266; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+bPeYj88gtPAEI6E/PIIKCqQBhsiIxznUBGyOV4wiTU=; b=V9LEg7GEdHdfQQ74hvUz9oyeK2Gk1i8LwSOPEdHEvirQ2aRC4A//su7h OQRv5uvMB2WW6ARNJsaYwXPK86bnYLX6gkjtvcqPcS+0TtVH7zQOilQsX YTjOLPKKMjw52odf38xuNkhp2jA7Vosc771dOVQ2tbE5lre3p0jnT8Hgu Z51MPlr7j5In/Y5/OgYuVI9NL7IYorAd8PIalyIGQibfwOOHukcLAocg8 isN0AWGZkqQ9/Ga0Y9aEfdnFsE4+cogirMyjQyciyHX1kEsO0eyPNRQIg cOCs5TnhGpf39O71KdwV7pTmbLH4TrXyRbb0ei+cVLKwnE6IcjTmts98T A==; X-IronPort-AV: E=McAfee;i="6600,9927,10817"; a="365603735" X-IronPort-AV: E=Sophos;i="6.02,210,1688454000"; d="scan'208";a="365603735" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2023 08:15:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10817"; a="773716704" X-IronPort-AV: E=Sophos;i="6.02,210,1688454000"; d="scan'208";a="773716704" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP; 29 Aug 2023 08:15:35 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qb0RK-004uce-0v; Tue, 29 Aug 2023 18:15:34 +0300 Date: Tue, 29 Aug 2023 18:15:34 +0300 From: Andy Shevchenko To: Biju Das Cc: Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] regulator: pv880x0: Drop CONFIG_OF ifdeffery Message-ID: References: <20230828172417.113631-1-biju.das.jz@bp.renesas.com> <20230828172417.113631-3-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230828172417.113631-3-biju.das.jz@bp.renesas.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 28, 2023 at 06:24:17PM +0100, Biju Das wrote: > Get rid of ugly CONFIG_OF ifdeffery by adding mod_devicetable.h include. Commit message needs to be improved. Inclusion of that header doesn't allow to do what you have done. Dropping of_match_ptr() does. And you need to explain that leaving OF table for non-OF system is fine and doesn't waste too much memory anyway. Look for the existing changes like this in the kernel history (`git log --no-merges --grep ...` at your service). -- With Best Regards, Andy Shevchenko