From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: "Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Charles Keepax" <ckeepax@opensource.cirrus.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: wm8580: Simplify probe()
Date: Tue, 29 Aug 2023 18:18:07 +0300 [thread overview]
Message-ID: <ZO4ML5Iykmt5xL2e@smile.fi.intel.com> (raw)
In-Reply-To: <20230828174019.119250-1-biju.das.jz@bp.renesas.com>
On Mon, Aug 28, 2023 at 06:40:19PM +0100, Biju Das wrote:
> Simplify probe() by replacing of_match_device->i2c_get_match_data() and
> extend matching support for ID table.
>
> While at it, remove comma in the terminator entry and simplify probe()
> by replacing dev_err->dev_err_probe().
dev_err() --> dev_err_probe()
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
...
> -static const struct of_device_id wm8580_of_match[] = {
> - { .compatible = "wlf,wm8580", .data = &wm8580_data },
> - { .compatible = "wlf,wm8581", .data = &wm8581_data },
> - { },
> -};
> -MODULE_DEVICE_TABLE(of, wm8580_of_match);
This doesn't change anything functional, please do it in a separate change.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-29 15:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 17:40 Biju Das
2023-08-29 15:18 ` Andy Shevchenko [this message]
2023-08-29 18:05 ` Biju Das
2023-09-11 23:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO4ML5Iykmt5xL2e@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®