From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CC02C83F19 for ; Wed, 30 Aug 2023 18:53:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245435AbjH3SwQ (ORCPT ); Wed, 30 Aug 2023 14:52:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244233AbjH3MsO (ORCPT ); Wed, 30 Aug 2023 08:48:14 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9ED8C132; Wed, 30 Aug 2023 05:48:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IOWE/0M8BlcymUq1i49NiJ36nIsTbEwhbzVvvXqFMks=; b=QymoGGmpy5KxS8E9NT36ocDUFW FnQpoW3j5rcesOV+zTgj13HGQTw5I5dMHi1Qh4AjEp5RNalo/sjDh8q61y5O1SNvKMaNG3z5tOK05 hXLu7s/J+VbEf+Ng2ivX+cNRVlCY+c1PIEZcwEgimLsbcZr/TBI5pV74seszbeQ4Ht/3tNFuqwx/j LukHJRG6ZJ8PhqCn89AtKH5QqGWV1gt72LUedCHf68SnTaGhvg5h1slQWuY+HF7+1xmEjwSMAqO2L 3KLO8gtaeQAnMLQ88GYi57SC4EJVZT+QWuFfHxKrv2MTQm7psgOH4P80HNUq2KTAlHuWvV1MGvghD 0QDvhsfw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qbKcE-00DVAO-1k; Wed, 30 Aug 2023 12:48:10 +0000 Date: Wed, 30 Aug 2023 05:48:10 -0700 From: Christoph Hellwig To: "Joel Fernandes (Google)" Cc: linux-kernel@vger.kernel.org, Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Zhen Lei , "Paul E . McKenney" , rcu@vger.kernel.org, Zqiang , linux-mm@kvack.org Subject: Re: [PATCH 1/2] mm/vmalloc: Add a safer version of find_vm_area() for debug Message-ID: References: <20230830110402.386898-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230830110402.386898-1-joel@joelfernandes.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 30, 2023 at 11:03:59AM +0000, Joel Fernandes (Google) wrote: > It is unsafe to dump vmalloc area information when trying to do so from > some contexts. Add a safer trylock version of the same function to do a > best-effort VMA finding and use it from vmalloc_dump_obj(). Seems like 2/2 to actually use this is missing?