From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1769EE49A4 for ; Sun, 20 Aug 2023 09:13:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230172AbjHTJN0 (ORCPT ); Sun, 20 Aug 2023 05:13:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229718AbjHTJNZ (ORCPT ); Sun, 20 Aug 2023 05:13:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F8EA31E9F5 for ; Sat, 19 Aug 2023 11:59:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 24E4A608C0 for ; Sat, 19 Aug 2023 18:59:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D32ADC433C8; Sat, 19 Aug 2023 18:59:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692471548; bh=muSsZQXeH5W5ZWIQQGcJYHD2XdcfeOyxVM9kY1wr7f8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i74yyXCF1RpoTfnu1exjW2hK1HDtKw2oAVHRpVll+Mt2HqVxOFnXWkki5CEEZFNcb 2gOurktbrZNr16tNwNkzOM2rd40R2TfPCei7W3ZewL6qgYUI3cSUL4y8i8fiaVHcQm i/8i5QlbHq+2OOh3cagGRp2QU+QkTKfN0FNz2c+fFxqAjEagqnJeJjJS0/kJffU0XU JHd4jdq4eSU7dh4PY8I7ZNvIsLRiq328kzObyS5l47RPqXhyZ8Z7xU7a0NDO60Ram+ khhDhMrwPC+aOzNJ6JlzrpQMl14uzaikCMDbV3w7dOcKGRhSfMh6wToV3rrs+M38i9 0wqRsPMeYRA5Q== Date: Sat, 19 Aug 2023 20:59:01 +0200 From: Simon Horman To: Furong Xu <0x1207@gmail.com> Cc: "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com, rock.xu@nio.com Subject: Re: [PATCH net-next v2 1/1] net: stmmac: Check more MAC HW features for XGMAC Core 3.20 Message-ID: References: <20230819105440.226892-1-0x1207@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230819105440.226892-1-0x1207@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 19, 2023 at 06:54:40PM +0800, Furong Xu wrote: > 1. XGMAC Core does not have hash_filter definition, it uses > vlhash(VLAN Hash Filtering) instead, skip hash_filter when XGMAC. > 2. Show exact size of Hash Table instead of raw register value. > 3. Show full description of safety features defined by Synopsys Databook. > 4. When safety feature is configured with no parity, or ECC only, > keep FSM Parity Checking disabled. > > Signed-off-by: Furong Xu <0x1207@gmail.com> > --- > Changes in v2: > - Rebase patch on net-next. Thanks Simon :) Likewise, thanks. Reviewed-by: Simon Horman