From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D690EE49AC for ; Mon, 21 Aug 2023 13:28:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235417AbjHUN2D (ORCPT ); Mon, 21 Aug 2023 09:28:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235409AbjHUN2C (ORCPT ); Mon, 21 Aug 2023 09:28:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2277AB4; Mon, 21 Aug 2023 06:27:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A8D086372D; Mon, 21 Aug 2023 13:27:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10220C433C8; Mon, 21 Aug 2023 13:27:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692624477; bh=i1odpy9BeOmNPTWxlRoAMrhEEMbIwj1pbTOY9KKPZeo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jPkNEl6/sZsNOO7hnkESOVkJiuLB3ImiCAMusKYgsIKfwzRl6u6U5anBlUN0ShREn cbMKP2iDLHEREbGxqIOWnMYvkm/7IgkDFGnIPH8fa4s9+1z7oAcz8lFAuzudl+vRDG 8uWQqXoIOsrHcHnMhNHAhSWd2MP/XPeI6h9f1erOjCMSwnJylHYgF/RF1dbd6ovAEw gQ2lEtbxt0NxmU0wYQAUuzubWa+vkNgTnqAWkUSOeCQzyy84SPVXembMrzduKwFYJG GV4fP+oZRyOeYBfMnexNb7d2eTgI1LrMhTTjszLSPGeY73z8KPCp4TFBdwlZWHYUaY VHiGqNnfp9mzQ== Received: from johan by theta with local (Exim 4.96) (envelope-from ) id 1qY4wi-0000h7-1A; Mon, 21 Aug 2023 15:27:52 +0200 Date: Mon, 21 Aug 2023 15:27:52 +0200 From: Johan Hovold To: Manikanta Pubbisetty Cc: Johan Hovold , Kalle Valo , Jeff Johnson , Bjorn Andersson , Manivannan Sadhasivam , Konrad Dybcio , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "Revert "wifi: ath11k: Enable threaded NAPI"" Message-ID: References: <20230809073432.4193-1-johan+linaro@kernel.org> <42f78c02-1ddc-cf1c-694f-abf9059dfb60@quicinc.com> <85d7c7a3-7a11-bae0-6f37-5da9280792aa@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <85d7c7a3-7a11-bae0-6f37-5da9280792aa@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 10, 2023 at 10:03:55AM +0530, Manikanta Pubbisetty wrote: > On 8/9/2023 2:46 PM, Johan Hovold wrote: > > On Wed, Aug 09, 2023 at 02:32:37PM +0530, Manikanta Pubbisetty wrote: > > > On 8/9/2023 1:04 PM, Johan Hovold wrote: > > > > This reverts commit d265ebe41c911314bd273c218a37088835959fa1. > > > > > > > > Disabling threaded NAPI causes the Lenovo ThinkPad X13s to hang (e.g. no > > > > more interrupts received) almost immediately during RX. > > > > > > > > Apparently something broke since commit 13aa2fb692d3 ("wifi: ath11k: > > > > Enable threaded NAPI") so that a simple revert is no longer possible. > > > What is the chip that Lenovo Thinkpad X13s is having? > > > > It's a WCN6855 (QCNFA765). > > WCN6855 & QCN9074 share the same driver code base since both being PCIe > devices. One working and another not working seems to be surprising. Do you > have a dmesg log when this problem occurred? I can't access the logs after I hit this bug (e.g. as there are no interrupts received from the keyboard) but when I trigger this from the console, there is nothing logged when the hang happens. Later, secondary errors are logged from other drivers that are no longer receiving interrupts either, and RCU detects a stall as I mentioned elsewhere. Johan