From: Pavel Machek <pavel@denx.de>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Winston Wen <wentao@uniontech.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Paulo Alcantara <pc@manguebit.com>,
Christian Brauner <brauner@kernel.org>,
Steve French <stfrench@microsoft.com>
Subject: Re: [PATCH AUTOSEL 4.14 7/9] fs/nls: make load_nls() take a const parameter
Date: Tue, 22 Aug 2023 12:46:21 +0200 [thread overview]
Message-ID: <ZOSR/YOFU66otZmO@duo.ucw.cz> (raw)
In-Reply-To: <20230813161427.1089101-7-sashal@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]
On Sun 2023-08-13 12:14:25, Sasha Levin wrote:
> From: Winston Wen <wentao@uniontech.com>
>
> [ Upstream commit c1ed39ec116272935528ca9b348b8ee79b0791da ]
>
> load_nls() take a char * parameter, use it to find nls module in list or
> construct the module name to load it.
>
> This change make load_nls() take a const parameter, so we don't need do
> some cast like this:
>
> ses->local_nls = load_nls((char *)ctx->local_nls->charset);
Nice cleanup, but should not be in stable.
Best regards,
Pavel
> Suggested-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Winston Wen <wentao@uniontech.com>
> Reviewed-by: Paulo Alcantara <pc@manguebit.com>
> Reviewed-by: Christian Brauner <brauner@kernel.org>
> Signed-off-by: Steve French <stfrench@microsoft.com>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
> fs/nls/nls_base.c | 4 ++--
> include/linux/nls.h | 2 +-
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2023-08-22 10:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-13 16:14 [PATCH AUTOSEL 4.14 1/9] 9p: virtio: make sure 'offs' is initialized in zc_request Sasha Levin
2023-08-13 16:14 ` [PATCH AUTOSEL 4.14 2/9] ASoC: da7219: Flush pending AAD IRQ when suspending Sasha Levin
2023-08-13 16:14 ` [PATCH AUTOSEL 4.14 3/9] ethernet: atheros: fix return value check in atl1c_tso_csum() Sasha Levin
2023-08-13 16:14 ` [PATCH AUTOSEL 4.14 4/9] vxlan: generalize vxlan_parse_gpe_hdr and remove unused args Sasha Levin
2023-08-22 10:45 ` Pavel Machek
2023-08-13 16:14 ` [PATCH AUTOSEL 4.14 5/9] m68k: Fix invalid .section syntax Sasha Levin
2023-08-13 16:14 ` [PATCH AUTOSEL 4.14 6/9] s390/dasd: use correct number of retries for ERP requests Sasha Levin
2023-08-13 16:14 ` [PATCH AUTOSEL 4.14 7/9] fs/nls: make load_nls() take a const parameter Sasha Levin
2023-08-22 10:46 ` Pavel Machek [this message]
2023-08-13 16:14 ` [PATCH AUTOSEL 4.14 8/9] ASoc: codecs: ES8316: Fix DMIC config Sasha Levin
2023-08-13 16:14 ` [PATCH AUTOSEL 4.14 9/9] security: keys: perform capable check only on privileged operations Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOSR/YOFU66otZmO@duo.ucw.cz \
--to=pavel@denx.de \
--cc=brauner@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pc@manguebit.com \
--cc=sashal@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=stable@vger.kernel.org \
--cc=stfrench@microsoft.com \
--cc=wentao@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®