From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v1 1/1] watchdog: simatic: Use idiomatic selection of P2SB
Date: Tue, 22 Aug 2023 18:13:49 +0300 [thread overview]
Message-ID: <ZOTQrf8VnJ8ljGK4@smile.fi.intel.com> (raw)
In-Reply-To: <a02b41a2-c390-8d05-ba2a-7a0a958013a8@redhat.com>
On Tue, Aug 22, 2023 at 04:50:14PM +0200, Hans de Goede wrote:
> On 8/22/23 16:18, Andy Shevchenko wrote:
> > While it's pretty much theoretical to be otherwise, make sure
> > that P2SB is selected only for X86. This is idiomatic dependency
> > which is used by all others who select it. Use it for Simatic
> > as well.
>
> Hmm, this already depends on SIEMENS_SIMATIC_IPC which itself
> depends on X86, so as you already say this is not really necessary...
Yes, but I want to keep that idiom, that's it.
It's purely style change.
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Note this depends on / applies on top of 2 other
> "config SIEMENS_SIMATIC_IPC_WDT" patches which
> are currently pending in pdx86/for-next:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next
>
> so this should probably be merged after 6.6-rc1 once
> these other changes have been merged.
Or with an Ack from watchdog maintainers... Whatever is the best for you,
folks. I'm fine with either choice.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-22 15:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 14:18 Andy Shevchenko
2023-08-22 14:50 ` Hans de Goede
2023-08-22 15:13 ` Andy Shevchenko [this message]
2023-08-22 16:39 ` Guenter Roeck
2023-08-22 17:15 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOTQrf8VnJ8ljGK4@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®