From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35267EE4993 for ; Tue, 22 Aug 2023 15:55:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237428AbjHVPzb (ORCPT ); Tue, 22 Aug 2023 11:55:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234344AbjHVPz2 (ORCPT ); Tue, 22 Aug 2023 11:55:28 -0400 Received: from mail-vk1-xa35.google.com (mail-vk1-xa35.google.com [IPv6:2607:f8b0:4864:20::a35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53C5EE7D for ; Tue, 22 Aug 2023 08:54:55 -0700 (PDT) Received: by mail-vk1-xa35.google.com with SMTP id 71dfb90a1353d-48d1412c5c5so939597e0c.3 for ; Tue, 22 Aug 2023 08:54:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1692719684; x=1693324484; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DyWiLtgW4rH+JKJqsR/UwcQBV8o5lraFKhrBSaT+Ps8=; b=NT9JTOvtFdmhasmygeVtSzIJVN74iudjI0QTUJny3AeS7qeldGSDrv7oJDtSS3KAC9 0dFApr2PitMRVcwgdL32fVPDHnH8mUAFHixpqtY7+Zj25SkL0AnJQxTqWtRl2cuQ4X9F Odv6PZizpLio4AtEU86+ByynRvlC2NaUeiQ3/Hu5fSOgwVcOc8d0LJBpfm32U9Vwjl9L a5A4saVCGeMgKEIGWXSplEAvDvLFwZHagf3JryhKcg+TBRs+yjve7FL01ECAzu2PK7iV QgYKnAvQDF4+JCzHTOY7KGQgGCsNGzwd78hQjM74mJ9v8RfYdaKIjSOUOsMiXMioPAY5 mhIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692719684; x=1693324484; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DyWiLtgW4rH+JKJqsR/UwcQBV8o5lraFKhrBSaT+Ps8=; b=j0Pe4T/mVuVEgvcnStJ0RynrDGK4aYPY3tOXqO5uNJUdj5yCw9hpDD2/0Si9jmdiPF Cv/MloAJj5gPZFJR7i3mGRNGm0yfGqSOlHhNK/UHgo07qivzz3DjTzPR/3zkKXHIR6JN 6nRxDcAfYRfmRkcqh4z6JGt5R5evoDt3KrbJiLXCoxkjhF5BhaFEQunHuYV6n7JxnQLp doc1QEn9ibyH7JQs6xHcTMtI9a3jtD91RZIWMe1HvIpVz/fU+Uy6FIivggZ8u4b4aCL6 ykJSPEjpjxVPJqHojeU2Z7p2EeLhGRhuNoCnG7U1qczcildzoysOPwm6ymOEWX9mn5Xv ZFaQ== X-Gm-Message-State: AOJu0Yxuwxzfg/gYHszZWP3ciNbNnWN71gEFazd0a+9Wfggo+NQ36Qn+ yM2NXIKbuFD6mFPWIRJiEqMj6Q== X-Google-Smtp-Source: AGHT+IHm+ZQkZnfqa1opBR5Uh1UPr48byTq5NCF+mGziAzbMuhJCaJmtH8trQUCfo/FpvCkPMs7e+Q== X-Received: by 2002:a1f:4e45:0:b0:48d:189b:6f3b with SMTP id c66-20020a1f4e45000000b0048d189b6f3bmr5428427vkb.12.1692719684095; Tue, 22 Aug 2023 08:54:44 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-25-194.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.25.194]) by smtp.gmail.com with ESMTPSA id c13-20020a0ce14d000000b006472b16d141sm1625144qvl.127.2023.08.22.08.54.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Aug 2023 08:54:43 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1qYTiM-00FBsa-Rd; Tue, 22 Aug 2023 12:54:42 -0300 Date: Tue, 22 Aug 2023 12:54:42 -0300 From: Jason Gunthorpe To: sharmaajay@linuxonhyperv.com Cc: Long Li , Leon Romanovsky , Dexuan Cui , Wei Liu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-rdma@vger.kernel.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ajay Sharma Subject: Re: [Patch v4 3/4] RDMA/mana_ib : Create adapter and Add error eq Message-ID: References: <1692719255-20183-1-git-send-email-sharmaajay@linuxonhyperv.com> <1692719255-20183-4-git-send-email-sharmaajay@linuxonhyperv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1692719255-20183-4-git-send-email-sharmaajay@linuxonhyperv.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 22, 2023 at 08:47:34AM -0700, sharmaajay@linuxonhyperv.com wrote: > +static void mana_ib_soc_event_handler(void *ctx, struct gdma_queue *queue, > + struct gdma_event *event) > +{ > + struct mana_ib_dev *mib_dev = (struct mana_ib_dev *)ctx; > + > + switch (event->type) { > + case GDMA_EQE_SOC_EVENT_NOTIFICATION: > + ibdev_dbg(&mib_dev->ib_dev, "Received SOC Notification"); > + break; > + case GDMA_EQE_SOC_EVENT_TEST: > + ibdev_dbg(&mib_dev->ib_dev, "Received SoC Test"); > + break; > + default: > + ibdev_dbg(&mib_dev->ib_dev, "Received unsolicited evt %d", > + event->type); > + } > +} Did I miss something? What is the point of all this? Please don't add test/dead code to the kernel. Come back when you have an actual use of events on this channel. Jason