From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EC78EE4993 for ; Tue, 22 Aug 2023 19:36:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230219AbjHVTgJ (ORCPT ); Tue, 22 Aug 2023 15:36:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229672AbjHVTgJ (ORCPT ); Tue, 22 Aug 2023 15:36:09 -0400 Received: from rere.qmqm.pl (rere.qmqm.pl [91.227.64.183]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21789DB for ; Tue, 22 Aug 2023 12:36:06 -0700 (PDT) Received: from remote.user (localhost [127.0.0.1]) by rere.qmqm.pl (Postfix) with ESMTPSA id 4RVfhz0fN2zCP; Tue, 22 Aug 2023 21:36:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1; t=1692732963; bh=dlAnPMbgJ2HyRDZFb7C5oXFmuHlLCCG41j4oHUAvcTg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LEIc7Vss66TLIMhtnIgjV9HdAzRToKwYSByIg1aZPJI6XX0hkeM/OOWtAWO/bP9QI t8q+j6YqMGeyGg1rt0Et7WdANDUk5+W37vI8+cEhcsbvuXyQnt6VCstCua2pnQclOA aYX82Oo+4xVxJVRL8KXyvhiYUv//CMsSf+0CRnTbVbUxJCCic96JmhnA/T7MLIPPxK A51/zZsyrUfExuN/ukd/KD3ApiLYdD/TGKdsnBU+DKb5z6QnpQcmlm1r9u5z5iJFZj rY8ddZmkabZ2v+Ve8zCIXVMVzvUiaeDli5sAguy9RPSV7y+t+1lriZikxZUmMZbrDr s/SYRfw0obUWQ== X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.8 at mail Date: Tue, 22 Aug 2023 21:36:01 +0200 From: =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= To: Lee Jones Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: core: Un-constify mfd_cell.of_reg Message-ID: References: <20230818155815.GY986605@google.com> <20230821081340.GD1380343@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230821081340.GD1380343@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 21, 2023 at 09:13:40AM +0100, Lee Jones wrote: > On Sat, 19 Aug 2023, Michał Mirosław wrote: > > > On Fri, Aug 18, 2023 at 04:58:15PM +0100, Lee Jones wrote: > > > On Wed, 16 Aug 2023, Michał Mirosław wrote: > > > > > > > of_reg is the only constant member of struct mfd_cell. It seems to be > > > > > > Sorry, what? > > > > > > struct mfd_cell { > > > const char *name; > > > [...] > > > const struct mfd_cell_acpi_match *acpi_match; > > > [...] > > > const struct software_node *swnode; > > > [...] > > > const char *of_compatible; > > > [...] > > > const u64 of_reg; > > > [...] > > > const struct resource *resources; > > > [...] > > > const char * const *parent_supplies; > > > [...] > > > }; > > [...] > > > > All those are pointers to const, not const fields themselves. Only > > `of_reg` is const regardless of the whole structure. > > Please make that clear in the commit message. Could you please help with the wording? I'm surprised being asked to explain a basic C language feature in a commit message to have a patch accepted. Could it be due to me using 'constant' instead of 'const' that made it confusing? Best Regards Michał Mirosław