From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B823EC3DA6F for ; Fri, 25 Aug 2023 10:05:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242799AbjHYKE5 (ORCPT ); Fri, 25 Aug 2023 06:04:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243210AbjHYKEk (ORCPT ); Fri, 25 Aug 2023 06:04:40 -0400 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A684B2110; Fri, 25 Aug 2023 03:04:33 -0700 (PDT) Received: from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 0AB382078C; Fri, 25 Aug 2023 12:04:30 +0200 (CEST) Date: Fri, 25 Aug 2023 12:04:28 +0200 From: Francesco Dolcini To: David Lin Cc: "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sharvari Harisangam , Pete Hsieh , "kvalo@kernel.org" , "amitkarwar@gmail.com" , "ganapathi017@gmail.com" , "huxinming820@gmail.com" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" Subject: Re: [PATCH v4 1/1] wifi: mwifiex: added code to support host mlme. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello David, thanks for your patch. On Tue, Aug 15, 2023 at 07:09:25AM +0000, David Lin wrote: > 1. For station mode first. > 2. This feature is a must for WPA3. > 3. Firmware key api version 2 is needed for this feature. > 4. The code is only enabled and tested with IW416. > 5. This feature is disabled for other chips. > > Signed-off-by: David Lin I think you are missing a few of the comments you received so far. - verify the recipient list, the list here was likely generated with an old kernel tree using an outdated MAINTAINERS file - you need to provide a changelog in your patch, otherwise is not possible for other to review - some concern were raised on the fact that this is tested only with IW416, we should have some confidence this is not creating regressions. Francesco