From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3555C83F11 for ; Mon, 28 Aug 2023 03:07:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229918AbjH1DHJ (ORCPT ); Sun, 27 Aug 2023 23:07:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229603AbjH1DGq (ORCPT ); Sun, 27 Aug 2023 23:06:46 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27E10119; Sun, 27 Aug 2023 20:06:43 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qaSZs-008Na8-4h; Mon, 28 Aug 2023 11:06:09 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Mon, 28 Aug 2023 11:06:09 +0800 Date: Mon, 28 Aug 2023 11:06:09 +0800 From: Herbert Xu To: mengkanglai Cc: Steffen Klassert , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Fengtao (fengtao, Euler)" , "Yanan (Euler)" Subject: Re: ltp testcases failed due to commit cf3128a7aca Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 28, 2023 at 02:12:12AM +0000, mengkanglai wrote: > > This command eventually use setkey -c to add spdadd entry failed: > spdadd $src_ipaddr $dst_ipaddr any >   -P out ipsec $protocol/tunnel/${src_ipaddr}-${dst_ipaddr}/use ; > > It returns Invalid argument. > > I found this failed due to commit cf3128a7aca(af_key: Reject optional tunnel/BEET mode templates in outbound policies), is latest ltp testcases are not adapted? Correct. The above specification makes no sense for an outbound policy as the SA can only be optional for inbound (where IPComp can be skipped for incompressible plaintext). So change the word "use" above to "require" and it should work. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt