From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FD1AC83F13 for ; Mon, 28 Aug 2023 10:11:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230334AbjH1KKu (ORCPT ); Mon, 28 Aug 2023 06:10:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230299AbjH1KKR (ORCPT ); Mon, 28 Aug 2023 06:10:17 -0400 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B92E9C6; Mon, 28 Aug 2023 03:10:11 -0700 (PDT) Received: from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 9297E20718; Mon, 28 Aug 2023 12:10:05 +0200 (CEST) Date: Mon, 28 Aug 2023 12:10:01 +0200 From: Francesco Dolcini To: David Lin Cc: Francesco Dolcini , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sharvari Harisangam , Pete Hsieh , "kvalo@kernel.org" , "amitkarwar@gmail.com" , "ganapathi017@gmail.com" , "huxinming820@gmail.com" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" Subject: Re: [EXT] Re: [PATCH v4 1/1] wifi: mwifiex: added code to support host mlme. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello David, On Mon, Aug 28, 2023 at 09:30:08AM +0000, David Lin wrote: > > On Tue, Aug 15, 2023 at 07:09:25AM +0000, David Lin wrote: > > > 1. For station mode first. > > > 2. This feature is a must for WPA3. > > > 3. Firmware key api version 2 is needed for this feature. > > > 4. The code is only enabled and tested with IW416. > > > 5. This feature is disabled for other chips. > > > > > > Signed-off-by: David Lin > > > > I think you are missing a few of the comments you received so far. > > > > - verify the recipient list, the list here was likely generated with an > > old kernel tree using an outdated MAINTAINERS file > > I followed your suggestion and issued the command on latest wireless test repository. Weird, you should have Brian Norris as recipient. > > - you need to provide a changelog in your patch, otherwise is not > > possible for other to review > > Yes, one the cover page. Whoops. I missed this since I am not cc: on this series and just found it by chance. I would have just expected to have the changelog together with the patch and not on the cover, given that it's a single patch. Sorry for the misunderstanding, I would appreciate if you could keep me in CC from now on, thanks. Francesco