From: Matthew Wilcox <willy@infradead.org>
To: Oliver Faso <erer1243@gmail.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs/sphinx: Explicitly convert Sphinx paths to str
Date: Sun, 10 Sep 2023 05:18:57 +0100 [thread overview]
Message-ID: <ZP1DsYlG+R/Y9fjr@casper.infradead.org> (raw)
In-Reply-To: <20230910040811.53046-1-erer1243@gmail.com>
On Sun, Sep 10, 2023 at 12:08:06AM -0400, Oliver Faso wrote:
> else:
> - doc = env.srcdir + "/" + env.docname + ":" + str(self.lineno)
> + doc = str(env.srcdir) + "/" + env.docname + ":" + str(self.lineno)
Would we be better off doing the path manipulation in Path, then converting
to string? ie:
doc = str(env.srcdir / env.docname) + ":" + str(self.lineno)
next prev parent reply other threads:[~2023-09-10 4:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-10 4:08 Oliver Faso
2023-09-10 4:18 ` Matthew Wilcox [this message]
2023-09-10 4:37 ` Oliver F
2023-09-27 14:09 ` Akira Yokosawa
2023-10-03 15:57 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZP1DsYlG+R/Y9fjr@casper.infradead.org \
--to=willy@infradead.org \
--cc=corbet@lwn.net \
--cc=erer1243@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®