From: Mark Brown <broonie@kernel.org>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Cc: Takashi Iwai <tiwai@suse.com>,
kernel@collabora.com, Jaroslav Kysela <perex@perex.cz>,
Shuah Khan <shuah@kernel.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] kselftest/alsa: Mark test plan as skipped when no cards are available
Date: Mon, 11 Sep 2023 15:29:00 +0100 [thread overview]
Message-ID: <ZP8kLM5ln2YBCHap@finisterre.sirena.org.uk> (raw)
In-Reply-To: <868a8f08-ba39-4550-8e7b-0572ea03c4e7@notapiano>
[-- Attachment #1: Type: text/plain, Size: 920 bytes --]
On Mon, Sep 11, 2023 at 08:35:37AM -0400, Nícolas F. R. A. Prado wrote:
> On Sat, Sep 09, 2023 at 12:08:22AM +0100, Mark Brown wrote:
> > Why?
> To better reflect the actual test plan status. If 0 tests were run, it doesn't
> really make sense to say that the test plan passed, rather it was skipped since
> nothing was run. So with this change, if there's a regression that prevents the
> soundcard driver from even probing, the result won't be "pass", but "skip", and
> the reason 'No soundcard available' will be in the logs.
So, I would interpret the overall result for the suite as being "No
errors were found in any of the cards discovered" if there is no
configuration file specified which enumerates the set of cards that are
expected (if there is a config file that's a different matter, we know
what we're expecting). I'm not sure that the different behaviour for 0
cards is super useful.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-09-11 22:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 18:12 Nícolas F. R. A. Prado
2023-09-08 23:08 ` Mark Brown
2023-09-11 12:35 ` Nícolas F. R. A. Prado
2023-09-11 14:29 ` Mark Brown [this message]
2023-09-12 19:23 ` Nícolas F. R. A. Prado
2023-09-13 15:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZP8kLM5ln2YBCHap@finisterre.sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=nfraprado@collabora.com \
--cc=perex@perex.cz \
--cc=shuah@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®