From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: "Andrzej Hajda" <andrzej.hajda@intel.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Douglas Anderson" <dianders@chromium.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Zhu Wang" <wangzhu9@huawei.com>,
"Adrián Larumbe" <adrian.larumbe@collabora.com>,
"Thierry Reding" <treding@nvidia.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Guillaume BRUN" <the.cheaterman@gmail.com>,
"Rob Herring" <robh@kernel.org>, "Sandor Yu" <Sandor.yu@nxp.com>,
"Sam Ravnborg" <sam@ravnborg.org>, "Ondrej Jirman" <megi@xff.cz>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 3/4] drm/bridge: Drop CONFIG_OF conditionals around of_node pointers
Date: Thu, 31 Aug 2023 19:14:52 +0300 [thread overview]
Message-ID: <ZPC8fJxQsRqJKK7k@smile.fi.intel.com> (raw)
In-Reply-To: <20230831080938.47454-4-biju.das.jz@bp.renesas.com>
On Thu, Aug 31, 2023 at 09:09:37AM +0100, Biju Das wrote:
> Having conditional around the of_node pointers turns out to make driver
> code use ugly #ifdef and #if blocks. So drop the conditionals.
...
> anx78xx->bridge.of_node = client->dev.of_node;
> panel_bridge->bridge.of_node = panel->dev->of_node;
> hdmi->bridge.of_node = pdev->dev.of_node;
> dsi->bridge.of_node = pdev->dev.of_node;
Yeah, I would really switch all of these to
bridge->fwnode = dev_fwnode(...);
But it's a suggestion for a separate change that I think can happen
sooner than later.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-31 16:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 8:09 [PATCH v6 0/4] Drop ID table and " Biju Das
2023-08-31 8:09 ` [PATCH v6 1/4] drm/bridge/analogix/anx78xx: Drop ID table Biju Das
2023-09-06 15:41 ` Doug Anderson
2023-08-31 8:09 ` [PATCH v6 2/4] drm/bridge: Drop conditionals around of_node pointers Biju Das
2023-09-06 15:42 ` Doug Anderson
2023-08-31 8:09 ` [PATCH v6 3/4] drm/bridge: Drop CONFIG_OF " Biju Das
2023-08-31 9:29 ` Laurent Pinchart
2023-08-31 16:14 ` Andy Shevchenko [this message]
2023-09-06 15:42 ` Doug Anderson
2023-08-31 8:09 ` [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional around *_of_get_bridge() Biju Das
2023-08-31 9:31 ` Laurent Pinchart
2023-08-31 10:47 ` Biju Das
2023-08-31 16:16 ` Andy Shevchenko
2023-09-06 15:42 ` Doug Anderson
2023-09-06 18:15 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPC8fJxQsRqJKK7k@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=Sandor.yu@nxp.com \
--cc=adrian.larumbe@collabora.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=megi@xff.cz \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=the.cheaterman@gmail.com \
--cc=treding@nvidia.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=ville.syrjala@linux.intel.com \
--cc=wangzhu9@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®