From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Biju Das" <biju.das.jz@bp.renesas.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Charles Keepax" <ckeepax@opensource.cirrus.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, "Biju Das" <biju.das.au@gmail.com>
Subject: Re: [PATCH v4 2/3] ASoC: wm8580: Remove trailing comma in the terminator entry
Date: Fri, 1 Sep 2023 16:19:50 +0300 [thread overview]
Message-ID: <ZPHk9tSC64clliFc@smile.fi.intel.com> (raw)
In-Reply-To: <baefefc8-55d7-430a-9ec5-2c17c4577d11@sirena.org.uk>
On Fri, Sep 01, 2023 at 01:54:58PM +0100, Mark Brown wrote:
> On Fri, Sep 01, 2023 at 11:53:29AM +0300, Andy Shevchenko wrote:
> > On Fri, Sep 01, 2023 at 07:59:51AM +0100, Biju Das wrote:
>
> > > Remove trailing comma in the terminator entry for OF table.
>
> > You are so fast :-)
> > This will produce an unneeded churn as you touch the same line twice in a row.
>
> So do reviews which focus on very pedantic issues like this one...
If you fine with a series as is, take it!
It's really nothing to bikeshed about.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-01 13:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 6:59 [PATCH v4 0/3] Match data improvements for wm8580 driver Biju Das
2023-09-01 6:59 ` [PATCH v4 1/3] ASoC: wm8580: Simplify probe() Biju Das
2023-09-01 6:59 ` [PATCH v4 2/3] ASoC: wm8580: Remove trailing comma in the terminator entry Biju Das
2023-09-01 8:18 ` Charles Keepax
2023-09-01 8:53 ` Andy Shevchenko
2023-09-01 12:54 ` Mark Brown
2023-09-01 13:19 ` Andy Shevchenko [this message]
2023-09-01 13:33 ` Mark Brown
2023-09-01 6:59 ` [PATCH v4 3/3] ASoC: wm8580: Move OF table Biju Das
2023-09-01 8:18 ` Charles Keepax
2023-09-11 23:57 ` [PATCH v4 0/3] Match data improvements for wm8580 driver Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPHk9tSC64clliFc@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®