mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kernel test robot <philip.li@intel.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
	Matti Vaittinen <mazziesaccount@gmail.com>
Cc: <llvm@lists.linux.dev>, <oe-kbuild-all@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>, Mark Brown <broonie@kernel.org>
Subject: kernel/reboot.c:559: warning: Function parameter or member 'poweroff_delay_ms' not described in 'hw_failure_emergency_poweroff'
Date: Mon, 4 Sep 2023 08:57:02 +0800	[thread overview]
Message-ID: <ZPUrXvIVwtVmPvzI@rli9-mobl> (raw)

[-- Attachment #1: Type: text/plain, Size: 2637 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   92901222f83d988617aee37680cb29e1a743b5e4
commit: dfa19b11385d4cf8f0242fd93e2073e25183c331 reboot: Add hardware protection power-off
date:   2 years, 2 months ago
:::::: branch date: 21 hours ago
:::::: commit date: 2 years, 2 months ago
config: i386-allnoconfig (attached as .config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (attached as reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309040349.HLOK1O5I-lkp@intel.com/

All warnings (new ones prefixed by >>):

   kernel/reboot.c:215: warning: Function parameter or member 'cmd' not described in 'do_kernel_restart'
>> kernel/reboot.c:559: warning: Function parameter or member 'poweroff_delay_ms' not described in 'hw_failure_emergency_poweroff'


vim +559 kernel/reboot.c

dfa19b11385d4cf Matti Vaittinen 2021-06-03  548  
dfa19b11385d4cf Matti Vaittinen 2021-06-03  549  static DECLARE_DELAYED_WORK(hw_failure_emergency_poweroff_work,
dfa19b11385d4cf Matti Vaittinen 2021-06-03  550  			    hw_failure_emergency_poweroff_func);
dfa19b11385d4cf Matti Vaittinen 2021-06-03  551  
dfa19b11385d4cf Matti Vaittinen 2021-06-03  552  /**
dfa19b11385d4cf Matti Vaittinen 2021-06-03  553   * hw_failure_emergency_poweroff - Trigger an emergency system poweroff
dfa19b11385d4cf Matti Vaittinen 2021-06-03  554   *
dfa19b11385d4cf Matti Vaittinen 2021-06-03  555   * This may be called from any critical situation to trigger a system shutdown
dfa19b11385d4cf Matti Vaittinen 2021-06-03  556   * after a given period of time. If time is negative this is not scheduled.
dfa19b11385d4cf Matti Vaittinen 2021-06-03  557   */
dfa19b11385d4cf Matti Vaittinen 2021-06-03  558  static void hw_failure_emergency_poweroff(int poweroff_delay_ms)
dfa19b11385d4cf Matti Vaittinen 2021-06-03 @559  {
dfa19b11385d4cf Matti Vaittinen 2021-06-03  560  	if (poweroff_delay_ms <= 0)
dfa19b11385d4cf Matti Vaittinen 2021-06-03  561  		return;
dfa19b11385d4cf Matti Vaittinen 2021-06-03  562  	schedule_delayed_work(&hw_failure_emergency_poweroff_work,
dfa19b11385d4cf Matti Vaittinen 2021-06-03  563  			      msecs_to_jiffies(poweroff_delay_ms));
dfa19b11385d4cf Matti Vaittinen 2021-06-03  564  }
dfa19b11385d4cf Matti Vaittinen 2021-06-03  565  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 8755 bytes --]

[-- Attachment #3: reproduce --]
[-- Type: text/plain, Size: 837 bytes --]

reproduce (this is a W=1 build):
        mkdir -p ~/bin
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=dfa19b11385d4cf8f0242fd93e2073e25183c331
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout dfa19b11385d4cf8f0242fd93e2073e25183c331
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=i386 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

             reply	other threads:[~2023-09-04  0:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-04  0:57 kernel test robot [this message]
2023-10-11  1:52 kernel test robot
2023-11-12  5:40 kernel test robot
2023-11-19  8:28 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZPUrXvIVwtVmPvzI@rli9-mobl \
    --to=philip.li@intel.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=matti.vaittinen@fi.rohmeurope.com \
    --cc=mazziesaccount@gmail.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®