From: Yi Sun <yi.sun@intel.com>
To: Ingo Molnar <mingo@kernel.org>, <dave.hansen@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>, <tglx@linutronix.de>,
<linux-kernel@vger.kernel.org>, <x86@kernel.org>,
<sohil.mehta@intel.com>, <ilpo.jarvinen@linux.intel.com>,
<heng.su@intel.com>, <tony.luck@intel.com>,
<dave.hansen@linux.intel.com>, <yi.sun@intel.intel.com>
Subject: Re: [PATCH v6 1/3] x86/fpu: Measure the Latency of XSAVES and XRSTORS
Date: Fri, 8 Sep 2023 08:24:04 +0800 [thread overview]
Message-ID: <ZPpppPyeob9O8Yy4@ysun46-mobl.ccr.corp.intel.com> (raw)
In-Reply-To: <ZPj3BpLlGkBeYcW7@gmail.com>
On 07.09.2023 00:02, Ingo Molnar wrote:
>
>* Dave Hansen <dave.hansen@intel.com> wrote:
>
>> On 9/6/23 02:18, Yi Sun wrote:
>> > Or just use PT
>>
>> I'd really like to be able to use this mechanism across a wide range of
>> systems over time and vendors. For instance, if Intel's AVX512 XSAVE
>> implementation is much faster than AMD's, it would be nice to show some
>> apples-to-apples data to motivate AMD to do better. We can't do that
>> with PT.
>
>Ack - and with the explicit tooling support, it's also very easy to provide
>such numbers.
>
>As long as the regular FPU code paths do not get new tracing overhead
>added, this looks like a useful tool.
>
>Thanks,
>
> Ingo
Hi Ingo and Dave,
We have been running the tool since kernel v5.19, and the patch set has
been tested in our internal repository for several months.
Additionally, we have implemented a test suite of micro-benchmark in user
space that works with this kernel trace, and it will be open-sourced soon.
With all these tools, we have obtained useful data, and we haven't
encountered any issues.
It would be great for the quality of X86 SIMD instructions if the patch
could catch up kernel v6.6.
Thanks
--Sun, Yi
next prev parent reply other threads:[~2023-09-08 0:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 14:34 [PATCH v6 0/3] x86/fpu Measure the Latency of XSAVES and Yi Sun
2023-09-01 14:34 ` [PATCH v6 1/3] x86/fpu: Measure the Latency of XSAVES and XRSTORS Yi Sun
2023-09-02 10:49 ` Ingo Molnar
2023-09-02 19:09 ` Andi Kleen
2023-09-06 9:18 ` Yi Sun
2023-09-06 18:49 ` Dave Hansen
2023-09-06 22:02 ` Ingo Molnar
2023-09-08 0:24 ` Yi Sun [this message]
2023-09-06 8:47 ` Yi Sun
2023-09-15 9:54 ` Ingo Molnar
2023-09-01 14:34 ` [PATCH v6 2/3] tools/testing/fpu: Add script to consume trace log of xsaves latency Yi Sun
2023-09-01 14:34 ` [PATCH v6 3/3] tools/testing/fpu: Add a 'count' column Yi Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPpppPyeob9O8Yy4@ysun46-mobl.ccr.corp.intel.com \
--to=yi.sun@intel.com \
--cc=ak@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=heng.su@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=sohil.mehta@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yi.sun@intel.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®