From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EFD3EEB571 for ; Fri, 8 Sep 2023 23:09:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244234AbjIHXJw (ORCPT ); Fri, 8 Sep 2023 19:09:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231314AbjIHXJv (ORCPT ); Fri, 8 Sep 2023 19:09:51 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AA5B1FE5; Fri, 8 Sep 2023 16:09:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=r7DXMMG8lphyN1UYT/bdqivjwbJYfjhTJFNgrVjQWJQ=; b=MIVUvcTZhlZQmiAIATHfNHIKVO CJhnk788m6vic6dye+YMPr2UEzzGxKosZEX2+BqKuM1BdlPQHPzRQGrzmxqKTMBxHDr+ZJXS97qeQ xHOnlbO/94akhRCatQ2Zc4pKvw0UH3SbzYruUX/iHZ7JvTS3CIk6ibVxkAuEIAR6rNwgGBBkFnaTp l0l/Zx28gD/dgjZ3owAYXUGk99MlNFCC8/XAV4IhQ1vo9bIAiyU33YEAtMy+Y/zEMzzRoqQa5SRuW zI5XMt1bdzbGutzevigArC3YwxvoAtfLqduxeK7zoWa7mx/vtfv4+scIKgHUDxSEcpP8ujhTnAV+K IMz7pbQw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qekbf-00Efj4-2D; Fri, 08 Sep 2023 23:09:43 +0000 Date: Fri, 8 Sep 2023 16:09:43 -0700 From: Luis Chamberlain To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable , Stefan Lippers-Hollmann , Mauro Carvalho Chehab , Christoph Hellwig , linux-media@vger.kernel.org, linux-modules@vger.kernel.org Subject: Re: [PATCH] media: dvb: symbol fixup for dvb_attach() Message-ID: References: <20230908092035.3815268-2-gregkh@linuxfoundation.org> <2023090852-stoppable-jackpot-549f@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2023090852-stoppable-jackpot-549f@gregkh> Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 08, 2023 at 05:35:07PM +0100, Greg Kroah-Hartman wrote: > On Fri, Sep 08, 2023 at 09:21:29AM -0700, Luis Chamberlain wrote: > > On Fri, Sep 08, 2023 at 10:20:36AM +0100, Greg Kroah-Hartman wrote: > > > In commit 9011e49d54dc ("modules: only allow symbol_get of > > > EXPORT_SYMBOL_GPL modules") the use of symbol_get is properly restricted > > > to GPL-only marked symbols. This interacts oddly with the DVB logic > > > which only uses dvb_attach() to load the dvb driver which then uses > > > symbol_get(). > > > > > > Fix this up by properly marking all of the dvb_attach attach symbols as > > > EXPORT_SYMBOL_GPL(). > > > > > > Fixes: 9011e49d54dc ("modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules") > > > Cc: stable > > > Reported-by: Stefan Lippers-Hollmann > > > Cc: Mauro Carvalho Chehab > > > Cc: Luis Chamberlain > > > Cc: Christoph Hellwig > > > Cc: linux-media@vger.kernel.org > > > Cc: linux-modules@vger.kernel.org > > > Signed-off-by: Greg Kroah-Hartman > > > --- > > > Luis, do you want to take this through your tree? Or Mauro's? Or I can > > > take it through mine, it should get to Linus soon as this is causing > > > regressions in his tree. > > > > You've done the work so it is up to you, whatever helps you expedite it > > as it already hit stable. Feel free to take it through your tree. > > If you ack it, I can take it now through my tree and send it to Linus > tomorrow. Sorry for the delay: Acked-by Luis Chamberlain Luis