From: Richard Cochran <richardcochran@gmail.com>
To: Sai Krishna <saikrishnag@marvell.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, sgoutham@marvell.com,
gakula@marvell.com, sbhatta@marvell.com, hkelam@marvell.com
Subject: Re: [net-next PATCH] octeontx2-pf: Enable PTP PPS output support
Date: Tue, 12 Sep 2023 14:29:21 -0700 [thread overview]
Message-ID: <ZQDYMRT/hoF7zuK4@hoboy.vegasvil.org> (raw)
In-Reply-To: <20230912175116.581412-1-saikrishnag@marvell.com>
On Tue, Sep 12, 2023 at 11:21:16PM +0530, Sai Krishna wrote:
> + case PTP_CLK_REQ_PEROUT:
> + if (rq->perout.flags)
> + return -EOPNOTSUPP;
> +
> + if (rq->perout.index >= ptp_info->n_pins)
> + return -EINVAL;
> + if (on) {
> + period = rq->perout.period.sec * NSEC_PER_SEC +
> + rq->perout.period.nsec;
> + ptp_pps_on(ptp, on, period);
> + } else {
> + ptp_pps_on(ptp, on, period);
> }
> return 0;
> default:
> @@ -411,6 +425,7 @@ int otx2_ptp_init(struct otx2_nic *pfvf)
> .name = "OcteonTX2 PTP",
> .max_adj = 1000000000ull,
> .n_ext_ts = 1,
> + .n_per_out = 1,
Thanks for using the "per_out" API for PPS output instead of...
> .n_pins = 1,
> .pps = 0,
this one (which has a misleading name) !
Acked-by: Richard Cochran <richardcochran@gmail.com>
next prev parent reply other threads:[~2023-09-12 21:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 17:51 Sai Krishna
2023-09-12 21:29 ` Richard Cochran [this message]
2023-09-15 9:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQDYMRT/hoF7zuK4@hoboy.vegasvil.org \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saikrishnag@marvell.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®