From: Herbert Xu <herbert@gondor.apana.org.au>
To: Om Prakash Singh <quic_omprsing@quicinc.com>
Cc: neil.armstrong@linaro.org, konrad.dybcio@linaro.org,
agross@kernel.org, andersson@kernel.org, conor+dt@kernel.org,
davem@davemloft.net, devicetree@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
marijn.suijten@somainline.org, robh+dt@kernel.org,
vkoul@kernel.org
Subject: Re: [PATCH] crypto: qcom-rng: Add hwrng support
Date: Fri, 15 Sep 2023 18:19:01 +0800 [thread overview]
Message-ID: <ZQQvlXvGy8p01uJS@gondor.apana.org.au> (raw)
In-Reply-To: <20230901131502.1549809-1-quic_omprsing@quicinc.com>
On Fri, Sep 01, 2023 at 06:45:02PM +0530, Om Prakash Singh wrote:
>
> + qrng = (struct qcom_rng *)rng->priv;
Please stop using rng->priv, it is obsolete. Instead embed the
rng object inside qcom_rng.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2023-09-15 10:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 13:15 Om Prakash Singh
2023-09-01 14:46 ` Bjorn Andersson
2023-09-05 2:50 ` Om Prakash Singh
2023-09-05 8:33 ` Konrad Dybcio
2023-09-03 17:33 ` Krzysztof Kozlowski
2023-09-05 6:24 ` [PATCH V2] crypto: qcom-rng - Add hw_random interface support Om Prakash Singh
2023-09-05 8:34 ` Konrad Dybcio
2023-09-20 3:04 ` Om Prakash Singh
2023-09-22 15:16 ` Bjorn Andersson
2023-09-25 11:10 ` Om Prakash Singh
2023-09-15 10:19 ` Herbert Xu [this message]
2023-09-20 2:56 ` Om Prakash Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQQvlXvGy8p01uJS@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_omprsing@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®