From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54948EED60D for ; Fri, 15 Sep 2023 15:23:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236089AbjIOPX0 (ORCPT ); Fri, 15 Sep 2023 11:23:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236062AbjIOPXQ (ORCPT ); Fri, 15 Sep 2023 11:23:16 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CBD3E6D for ; Fri, 15 Sep 2023 08:23:09 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-68fbd5cd0ceso1957328b3a.1 for ; Fri, 15 Sep 2023 08:23:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1694791389; x=1695396189; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JzUny5ZDY3B8dwGvMbx7t3ZOXwBY6DGZ8A+gn9ETcXA=; b=0BdMv/t2kSwIcKkYEe7jYMeCfjq1Wys4SU/VqXRf8qbeN5IUQMoPXdh4U/Fq9S1eeb GfZVVox/pywXV/ZWA0zOGbRkpWqRZvsMjiRGk8xbuBToQe+nlkw4Zhni2V6VfEK03+rw 2qyXgbGZfiGXGzs6ADpgRasRS1rqM88EzCLxdV/fbAZUNZxqnf/b2PdQdq1MBzpjWfra 5aJLuSa7NjhIeLKbD6ODkJeUs73PtT86mwSYaIJ3d597u6BabQDpnqBMh5N1096YRydc oOo0xg677ZfTTyRzmzASBfkYkSAIhii21ZOAOtDZvpLWZovm4fV0f4Jpt4cWncUOXokW x+xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694791389; x=1695396189; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JzUny5ZDY3B8dwGvMbx7t3ZOXwBY6DGZ8A+gn9ETcXA=; b=Yyv7OPuK9pkfHF1yuDdpEfSPFtDGYsQEBHojk6Kl6fR5fi/3nDKbsmZ0D1Pe5nzOCF trBf4kP5zh3ytprs6VUg4wZ0q1jmPhQPS+H1db0hNrUUbCPP4aA0HceJX/xRer+nS3zQ tOT5ZgOslfqTxJBg2u3LP8fjEpSQfB0nPhCgs+3C9m8viuGZUbaGLu4pV8GV2XgtVTrU ZroP34srsk5hQa/BKyLV9UUzISh9h+zSRKHpe9M88i0FipYurcVL8TczPaeFZpVNZaa5 MaINzYAckQyZWvqCT6d/1fgj0i9ptFSptNkGOMXTHDINtE4VIHXjv2nVqzF9qJKF3nRh 5quA== X-Gm-Message-State: AOJu0YxQiGqEt34XLLriC08gAQWZxi5XzG+I0oO9HTG1yPtXR9OtDu4m mC9hdOOLlGmRu7ELQv5wODZcNw== X-Google-Smtp-Source: AGHT+IElDW4bTTqtNEHxEJSI2zqsGM7eb0Y6Wp/U3CPQiwi0iSahU1mcqFPPoZA/wBkxBNyUQ3xnlg== X-Received: by 2002:a05:6a00:3186:b0:690:1857:3349 with SMTP id bj6-20020a056a00318600b0069018573349mr1453397pfb.25.1694791389091; Fri, 15 Sep 2023 08:23:09 -0700 (PDT) Received: from ghost ([50.168.177.76]) by smtp.gmail.com with ESMTPSA id c15-20020aa78c0f000000b0068fb5e44827sm3087719pfd.67.2023.09.15.08.23.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 08:23:08 -0700 (PDT) Date: Fri, 15 Sep 2023 11:23:05 -0400 From: Charlie Jenkins To: Alexandre Ghiti Cc: Shuah Khan , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -fixes] riscv: kselftests: Fix mm build by removing testcases subdirectory Message-ID: References: <20230915100113.13131-1-alexghiti@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230915100113.13131-1-alexghiti@rivosinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 15, 2023 at 12:01:13PM +0200, Alexandre Ghiti wrote: > kselftests fails to build because the mm/testcases subdirectory is not > created and then the compiler fails to output the binary there. > > So fix this by simply removing this subdirectory which is not very > useful. > > Signed-off-by: Alexandre Ghiti > --- > tools/testing/selftests/riscv/mm/Makefile | 6 +++--- > .../selftests/riscv/mm/{testcases => }/mmap_bottomup.c | 2 +- > .../selftests/riscv/mm/{testcases => }/mmap_default.c | 2 +- > .../testing/selftests/riscv/mm/{testcases => }/mmap_test.h | 0 > .../testing/selftests/riscv/mm/{testcases => }/run_mmap.sh | 0 > 5 files changed, 5 insertions(+), 5 deletions(-) > rename tools/testing/selftests/riscv/mm/{testcases => }/mmap_bottomup.c (97%) > rename tools/testing/selftests/riscv/mm/{testcases => }/mmap_default.c (97%) > rename tools/testing/selftests/riscv/mm/{testcases => }/mmap_test.h (100%) > rename tools/testing/selftests/riscv/mm/{testcases => }/run_mmap.sh (100%) > > diff --git a/tools/testing/selftests/riscv/mm/Makefile b/tools/testing/selftests/riscv/mm/Makefile > index 11e0f0568923..c333263f2b27 100644 > --- a/tools/testing/selftests/riscv/mm/Makefile > +++ b/tools/testing/selftests/riscv/mm/Makefile > @@ -5,11 +5,11 @@ > # Additional include paths needed by kselftest.h and local headers > CFLAGS += -D_GNU_SOURCE -std=gnu99 -I. > > -TEST_GEN_FILES := testcases/mmap_default testcases/mmap_bottomup > +TEST_GEN_FILES := mmap_default mmap_bottomup > > -TEST_PROGS := testcases/run_mmap.sh > +TEST_PROGS := run_mmap.sh > > include ../../lib.mk > > -$(OUTPUT)/mm: testcases/mmap_default.c testcases/mmap_bottomup.c testcases/mmap_tests.h > +$(OUTPUT)/mm: mmap_default.c mmap_bottomup.c mmap_tests.h > $(CC) -o$@ $(CFLAGS) $(LDFLAGS) $^ > diff --git a/tools/testing/selftests/riscv/mm/testcases/mmap_bottomup.c b/tools/testing/selftests/riscv/mm/mmap_bottomup.c > similarity index 97% > rename from tools/testing/selftests/riscv/mm/testcases/mmap_bottomup.c > rename to tools/testing/selftests/riscv/mm/mmap_bottomup.c > index b29379f7e478..1757d19ca89b 100644 > --- a/tools/testing/selftests/riscv/mm/testcases/mmap_bottomup.c > +++ b/tools/testing/selftests/riscv/mm/mmap_bottomup.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0-only > #include > -#include > +#include > > #include "../../kselftest_harness.h" > > diff --git a/tools/testing/selftests/riscv/mm/testcases/mmap_default.c b/tools/testing/selftests/riscv/mm/mmap_default.c > similarity index 97% > rename from tools/testing/selftests/riscv/mm/testcases/mmap_default.c > rename to tools/testing/selftests/riscv/mm/mmap_default.c > index d1accb91b726..c63c60b9397e 100644 > --- a/tools/testing/selftests/riscv/mm/testcases/mmap_default.c > +++ b/tools/testing/selftests/riscv/mm/mmap_default.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0-only > #include > -#include > +#include > > #include "../../kselftest_harness.h" > > diff --git a/tools/testing/selftests/riscv/mm/testcases/mmap_test.h b/tools/testing/selftests/riscv/mm/mmap_test.h > similarity index 100% > rename from tools/testing/selftests/riscv/mm/testcases/mmap_test.h > rename to tools/testing/selftests/riscv/mm/mmap_test.h > diff --git a/tools/testing/selftests/riscv/mm/testcases/run_mmap.sh b/tools/testing/selftests/riscv/mm/run_mmap.sh > similarity index 100% > rename from tools/testing/selftests/riscv/mm/testcases/run_mmap.sh > rename to tools/testing/selftests/riscv/mm/run_mmap.sh > -- > 2.39.2 > Fixes the problem. Reviewed-by: Charlie Jenkins - Charlie