From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Mark Pearson <mpearson-lenovo@squebb.ca>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mark Pearson <markpearson@lenovo.com>,
Mark Gross <markgross@kernel.org>
Subject: Re: [PATCH v1 1/2] platform/x86: think-lmi: Replace kstrdup() + strreplace() with kstrdup_and_replace()
Date: Mon, 18 Sep 2023 16:50:09 +0300 [thread overview]
Message-ID: <ZQhVkb9XYvjd7GlJ@smile.fi.intel.com> (raw)
In-Reply-To: <77bde3cf-ca94-1cdb-53d8-39df22f8c551@redhat.com>
On Mon, Sep 18, 2023 at 02:30:28PM +0200, Hans de Goede wrote:
> On 9/13/23 11:27, Andy Shevchenko wrote:
> > Replace open coded functionalify of kstrdup_and_replace() with a call.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Thank you for the patches, but this one does not apply
> cleanly.
`git am -C1 ...` works for me.
> Can you please rebase the series on top of my latest review-hans branch ?
But fine, no problem, I'm about to send a v2,
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-09-18 15:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 9:27 Andy Shevchenko
2023-09-13 9:27 ` [PATCH v1 2/2] platform/x86: think-lmi: Use strreplace() to replace a character by nul Andy Shevchenko
2023-09-13 13:17 ` Mark Pearson
2023-09-15 14:57 ` Ilpo Järvinen
2023-09-18 14:48 ` Rasmus Villemoes
2023-09-18 15:38 ` Andy Shevchenko
2023-09-13 13:15 ` [PATCH v1 1/2] platform/x86: think-lmi: Replace kstrdup() + strreplace() with kstrdup_and_replace() Mark Pearson
2023-09-15 14:57 ` Ilpo Järvinen
2023-09-18 12:30 ` Hans de Goede
2023-09-18 13:50 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQhVkb9XYvjd7GlJ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=markpearson@lenovo.com \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®