From: Tejun Heo <tj@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-kernel@vger.kernel.org, dhavale@google.com
Subject: Re: [PATCH] workqueue: Remove duplicate worqueue attributes allocation
Date: Mon, 18 Sep 2023 08:45:28 -1000 [thread overview]
Message-ID: <ZQiayAKAW6sjseiR@slm.duckdns.org> (raw)
In-Reply-To: <20230906173904.475722-1-catalin.marinas@arm.com>
On Wed, Sep 06, 2023 at 06:39:04PM +0100, Catalin Marinas wrote:
> Commit 84193c07105c ("workqueue: Generalize unbound CPU pods")
> inadvertently introduced another call to alloc_workqueue_attrs()
> overriding the pointer returned by a previous alloc_workqueue_attrs() a
> few lines up in workqueue_init_early(). This leads to a kmemleak report:
>
> unreferenced object 0xffff000040015000 (size 96):
> comm "swapper/0", pid 0, jiffies 4294892296 (age 163.956s)
> hex dump (first 32 bytes):
> 00 00 00 00 00 00 00 00 03 00 00 00 00 00 00 00 ................
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> backtrace:
> [<000000004cec0d50>] __kmem_cache_alloc_node+0x1c4/0x288
> [<0000000083361c2a>] kmalloc_trace+0x20/0x2c
> [<000000005ca61f11>] workqueue_init_early+0xe4/0x538
> [<000000004e6ea358>] start_kernel+0x23c/0x5ec
> [<00000000aea9761e>] __primary_switched+0xbc/0xc4
>
> Remove the first allocation.
>
> Fixes: 84193c07105c ("workqueue: Generalize unbound CPU pods")
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Tejun Heo <tj@kernel.org>
Another version of this patch has been applied to wq/for-6.6-fixes.
Thanks.
--
tejun
prev parent reply other threads:[~2023-09-18 18:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 17:39 Catalin Marinas
2023-09-07 4:13 ` Sandeep Dhavale
2023-09-12 12:51 ` Matthieu Baerts
2023-09-18 18:45 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQiayAKAW6sjseiR@slm.duckdns.org \
--to=tj@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dhavale@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®