From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A582CE79A8 for ; Tue, 19 Sep 2023 20:02:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233092AbjISUCk (ORCPT ); Tue, 19 Sep 2023 16:02:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232088AbjISUCi (ORCPT ); Tue, 19 Sep 2023 16:02:38 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AFC49C; Tue, 19 Sep 2023 13:02:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695153753; x=1726689753; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=nnkcHJoKa+TopEBsm/t7nStp61sWfB59HZAe0jK6KQQ=; b=Iw678Az/ZU46qcY1jU8pL8O4eA0KLJC5v6+LOAsYqHkmnVIzrIdc4lRH ugHHShg1ZNk/FxVnDOWzmZTM2x3QrCoJHCc4YjoAdp94eRvPHTe9GYwCk 0gqnr90X0a36t4ucfba64JgZghWEu2RNQl3LwClsEMWXG4JjsHjC1ZgCP 3f/nR4E6eOl7Ar2V+rxtTpZdJi66XcNn+fRI4Mam/aBfvGS1XJTJKkrEg L7l6wf3iruonlkJ8oZ8OqtoVGBKqz9NyCkFc1tmSDhnzNpe14PpYTu5Pz 00hW37lCATUZPcTK8HZt0+ihtgk0TTqOEkwXjQ7RRuVEC3XrhX4azSp3j A==; X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="410971225" X-IronPort-AV: E=Sophos;i="6.02,160,1688454000"; d="scan'208";a="410971225" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2023 13:02:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="1077115879" X-IronPort-AV: E=Sophos;i="6.02,160,1688454000"; d="scan'208";a="1077115879" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2023 13:02:29 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC0) (envelope-from ) id 1qigvR-0000000Ezza-4Amk; Tue, 19 Sep 2023 23:02:25 +0300 Date: Tue, 19 Sep 2023 23:02:25 +0300 From: Andy Shevchenko To: "Rafael J. Wysocki" , Rob Herring , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , "Rafael J. Wysocki" , Len Brown , Russell King , Rob Herring , Frank Rowand , Peng Fan Subject: Re: [PATCH v1 1/1] amba: bus: balance firmware node reference counting Message-ID: References: <20230824162654.2890992-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 19, 2023 at 11:01:37PM +0300, Andy Shevchenko wrote: > On Thu, Aug 24, 2023 at 07:26:54PM +0300, Andy Shevchenko wrote: > > Currently the ACPI code doesn't bump the reference count of > > the firmware node, while OF counter part does. Not that it's > > a problem right now, since ACPI doesn't really use the reference > > counting for firmware nodes, it still makes sense to make code > > robust against any changes done there. For this, > > - switch ACPI case to use device_set_node() to be unified with OF > > - move reference counting to amba_device_add() > > - switch to use firmware nodes instead of OF ones > > > > In the result we will have reference counting done in the same module > > for all callers independently on the nature of firmware node behind. > > Any comment on this? I would like to have this applied so I can do something > similar to the platform driver code. Ah, I see, I missed LKP run on this, I'll send a v2 perhaps later on this week. -- With Best Regards, Andy Shevchenko