From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Marc Zyngier <maz@kernel.org>,
Johan Hovold <johan+linaro@kernel.org>,
linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [PATCH v1 1/1] irqdomain: Check virq for 0 before use in irq_dispose_mapping()
Date: Tue, 19 Sep 2023 22:59:53 +0300 [thread overview]
Message-ID: <ZQn9uR0o8QHXjN69@smile.fi.intel.com> (raw)
In-Reply-To: <20230822135136.2138380-1-andriy.shevchenko@linux.intel.com>
On Tue, Aug 22, 2023 at 04:51:36PM +0300, Andy Shevchenko wrote:
> It's a bit hard to read the logic since we use virq before checking
> it for 0. Rearrange the code to make it better to understand.
>
> This, in particular, should clearly answer the question whether caller
> need to perform this check or not, and we have plenty places for both
> variants, confirming a confusion.
>
> Fun fact that the new code is shorter:
>
> Function old new delta
> irq_dispose_mapping 278 271 -7
> Total: Before=11625, After=11618, chg -0.06%
>
> when compiled by GCC on Debian for x86_64.
Any comment on this?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-09-19 20:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 13:51 Andy Shevchenko
2023-09-19 19:59 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQn9uR0o8QHXjN69@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=johan+linaro@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®