mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@kernel.org>
To: Fedor Pchelkin <pchelkin@ispras.ru>
Cc: Hannes Reinecke <hare@suse.de>, Alasdair Kergon <agk@redhat.com>,
	dm-devel@redhat.com, linux-kernel@vger.kernel.org,
	Alexey Khoroshilov <khoroshilov@ispras.ru>,
	lvc-project@linuxtesting.org, stable@vger.kernel.org
Subject: Re: dm-zoned: free dmz->ddev array in dmz_put_zoned_device
Date: Wed, 20 Sep 2023 13:54:05 -0400	[thread overview]
Message-ID: <ZQsxvY12z+/yYcR6@redhat.com> (raw)
In-Reply-To: <vdtvo2av3upya6mugjyiqo2hfnn6q4dpofoku6rvrtgmycgbrp@scpcnu3ta7ch>

On Wed, Sep 20 2023 at 10:35P -0400,
Fedor Pchelkin <pchelkin@ispras.ru> wrote:

> On 23/09/20 04:06PM, Hannes Reinecke wrote:
> > On 9/20/23 12:51, Fedor Pchelkin wrote:
> > > Commit 4dba12881f88 ("dm zoned: support arbitrary number of devices")
> > > made the pointers to additional zoned devices to be stored in a
> > > dynamically allocated dmz->ddev array. However, this array is not freed.
> > > 
> > > Free it when cleaning up zoned device information inside
> > > dmz_put_zoned_device(). Assigning NULL to dmz->ddev elements doesn't make
> > > sense there as they are not supposed to be reused later and the whole dmz
> > > target structure is being cleaned anyway.
> > > 
> > > Found by Linux Verification Center (linuxtesting.org).
> > > 
> > > Fixes: 4dba12881f88 ("dm zoned: support arbitrary number of devices")
> > > Cc: stable@vger.kernel.org
> > > Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
> > > ---
> > >   drivers/md/dm-zoned-target.c | 8 +++-----
> > >   1 file changed, 3 insertions(+), 5 deletions(-)
> > > 
> > > diff --git a/drivers/md/dm-zoned-target.c b/drivers/md/dm-zoned-target.c
> > > index ad8e670a2f9b..e25cd9db6275 100644
> > > --- a/drivers/md/dm-zoned-target.c
> > > +++ b/drivers/md/dm-zoned-target.c
> > > @@ -753,12 +753,10 @@ static void dmz_put_zoned_device(struct dm_target *ti)
> > >   	struct dmz_target *dmz = ti->private;
> > >   	int i;
> > > -	for (i = 0; i < dmz->nr_ddevs; i++) {
> > > -		if (dmz->ddev[i]) {
> > > +	for (i = 0; i < dmz->nr_ddevs; i++)
> > > +		if (dmz->ddev[i])
> > >   			dm_put_device(ti, dmz->ddev[i]);
> > > -			dmz->ddev[i] = NULL;
> > > -		}
> > > -	}
> > > +	kfree(dmz->ddev);
> > >   }
> > >   static int dmz_fixup_devices(struct dm_target *ti)
> > 
> > Hmm. I'm not that happy with it; dmz_put_zoned_device() is using dm_target
> > as an argument, whereas all of the functions surrounding the call sites is
> > using the dmz_target directly.
> > 
> > Mind to modify the function to use 'struct dmz_target' as an argument?
> 
> dm_target is required inside dmz_put_zoned_device() for dm_put_device()
> calls. I can't see a way for referencing it via dmz_target. Do you mean
> passing additional second argument like
>   dmz_put_zoned_device(struct dmz_target *dmz, struct dm_target *ti) ?

No, what you did is fine.  Not sure what Hannes is saying given only
passing dm_target has symmetry with dm_get_zoned_device (and
dmz_fixup_devices).

> BTW, I also think it can be renamed to dmz_put_zoned_devices().

I've renamed like you suggested and added a newline to
dmz_put_zoned_devices() and staged this fix in linux-next for
upstream inclusion before 6.6 final releases.

Mike

  reply	other threads:[~2023-09-20 17:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-20 10:51 [PATCH] " Fedor Pchelkin
2023-09-20 14:06 ` Hannes Reinecke
2023-09-20 14:35   ` Fedor Pchelkin
2023-09-20 17:54     ` Mike Snitzer [this message]
2023-09-20 18:56       ` Fedor Pchelkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZQsxvY12z+/yYcR6@redhat.com \
    --to=snitzer@kernel.org \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=hare@suse.de \
    --cc=khoroshilov@ispras.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvc-project@linuxtesting.org \
    --cc=pchelkin@ispras.ru \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®