From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Kent Gibson <warthog618@gmail.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
akpm@linux-foundation.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v5] gpio: sim: fix an invalid __free() usage
Date: Thu, 21 Sep 2023 12:45:00 +0300 [thread overview]
Message-ID: <ZQwQnA/W1TZDJivM@smile.fi.intel.com> (raw)
In-Reply-To: <CAMRc=MfvOL-ovQ89i7FASg=RoWHQPARGsc5Pxu9kC+roGqaE4g@mail.gmail.com>
On Thu, Sep 21, 2023 at 01:12:16AM -0700, Bartosz Golaszewski wrote:
> On Wed, 20 Sep 2023 15:43:47 +0200, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> said:
> > On Wed, Sep 20, 2023 at 09:32:53AM +0200, Bartosz Golaszewski wrote:
...
> > As for the material to be backported it's fine, but I'm wondering if we
> > actually can add the entries in a sorted manner, so we would need the exact
> > what I mentioned in previous review round, just search backwards to the first
> > satisfying entry. I don't believe the adding an entry to the list is a
> > hot-path, so would be fine to call list_sort().
>
> Given the need for the callback function, this would result in bigger code.
Is it a problem?
On the below I kinda agree.
> Also calling:
>
> list_add_tail();
> list_sort();
>
> is not very elegant. I would possibly go for adding list_add_sorted() but
> that's a separate change for the future.
Note, we do this for the GPIO bases already.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-21 20:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 7:32 Bartosz Golaszewski
2023-09-20 13:43 ` Andy Shevchenko
2023-09-21 8:12 ` Bartosz Golaszewski
2023-09-21 9:45 ` Andy Shevchenko [this message]
2023-09-22 8:54 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQwQnA/W1TZDJivM@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®