From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0289EE92FFB for ; Fri, 6 Oct 2023 08:24:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231154AbjJFIY5 (ORCPT ); Fri, 6 Oct 2023 04:24:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230076AbjJFIYx (ORCPT ); Fri, 6 Oct 2023 04:24:53 -0400 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C4C58FD; Fri, 6 Oct 2023 01:24:51 -0700 (PDT) Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1qog8g-0002lZ-00; Fri, 06 Oct 2023 10:24:50 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 2F811C01D1; Fri, 6 Oct 2023 10:21:15 +0200 (CEST) Date: Fri, 6 Oct 2023 10:21:15 +0200 From: Thomas Bogendoerfer To: Keguang Zhang Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH v3] MIPS: loongson32: Remove dma.h and nand.h Message-ID: References: <20230830133505.505597-1-keguang.zhang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230830133505.505597-1-keguang.zhang@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 30, 2023 at 09:35:05PM +0800, Keguang Zhang wrote: > Since commit 7b3415f581c7 ("MIPS: Loongson32: Remove > unused platform devices"), struct plat_ls1x_dma and plat_ls1x_nand > are unused. Then, dma.h and nand.h are useless. > Therefore, remove these useless header files. > > Signed-off-by: Keguang Zhang > Reviewed-by: Philippe Mathieu-Daudé > --- > V2 -> V3: Fix the build error > Add Reviewed-by tag from Philippe Mathieu-Daudé > V1 -> V2: Remove include of dma.h and nand.h > Update the commit message > --- > arch/mips/include/asm/mach-loongson32/dma.h | 21 --------------- > arch/mips/include/asm/mach-loongson32/nand.h | 26 ------------------- > .../include/asm/mach-loongson32/platform.h | 3 --- > arch/mips/loongson32/common/platform.c | 2 -- > arch/mips/loongson32/ls1b/board.c | 2 -- > 5 files changed, 54 deletions(-) > delete mode 100644 arch/mips/include/asm/mach-loongson32/dma.h > delete mode 100644 arch/mips/include/asm/mach-loongson32/nand.h applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]