From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A1E4E92FF9 for ; Fri, 6 Oct 2023 08:25:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231325AbjJFIZO (ORCPT ); Fri, 6 Oct 2023 04:25:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231162AbjJFIZE (ORCPT ); Fri, 6 Oct 2023 04:25:04 -0400 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 46660112; Fri, 6 Oct 2023 01:24:57 -0700 (PDT) Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1qog8g-0002lV-00; Fri, 06 Oct 2023 10:24:50 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id CBB03C01C1; Fri, 6 Oct 2023 10:06:02 +0200 (CEST) Date: Fri, 6 Oct 2023 10:06:02 +0200 From: Thomas Bogendoerfer To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, arnd@arndb.de, jiaxun.yang@flygoat.com, mpe@ellerman.id.au, geert@linux-m68k.org, mcgrof@kernel.org, hch@infradead.org, f.fainelli@gmail.com, deller@gmx.de, Serge Semin , Huacai Chen , linux-mips@vger.kernel.org Subject: Re: [PATCH v5 4/4] mips: io: remove duplicated codes Message-ID: References: <20230921110424.215592-1-bhe@redhat.com> <20230921110424.215592-5-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230921110424.215592-5-bhe@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 21, 2023 at 07:04:24PM +0800, Baoquan He wrote: > By adding support, the duplicated phys_to_virt > can be removed to use the default version in . > > Meanwhile move isa_bus_to_virt() down below including > to fix the compiling error of missing phys_to_virt definition. > > Signed-off-by: Baoquan He > Cc: Thomas Bogendoerfer > Cc: Geert Uytterhoeven > Cc: Helge Deller > Cc: Serge Semin > Cc: Florian Fainelli > Cc: Huacai Chen > Cc: Jiaxun Yang > Cc: linux-mips@vger.kernel.org > --- > arch/mips/include/asm/io.h | 28 +++++----------------------- > 1 file changed, 5 insertions(+), 23 deletions(-) Acked-by: Thomas Bogendoerfer -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]